Updated Jaeger deployment #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonjaChevre
commented
Dec 13, 2023
•
SonjaChevre
commented
- removed the OpenTelemetry collector as this is no longer needed with the latest Jaeger update. I plan to add another deployment in the future with the OTel collector
- updated MDCB deployment to make sure that distributed traces will also be collected for the data plane gateways, in case OTel and MDCB are used together
- Minor text improvements, added link to the documentation
* remove the OpenTelemetry collector as this is no longer needed with the latest Jaeger update. I plan to add another deployment in the future with the OTel collector * updated MDCB deployment to make sure that distributed traces will also be collected for the data plane gateways, in case OTel and MDCB are used together * Minor text improvements, added link to the documentation
|
@mativm02 I think it would be great if you could review the changes I made to OTel |
davegarvey
reviewed
Dec 13, 2023
added jaeger version
davegarvey
approved these changes
Dec 14, 2023
|
hi @tbuchaillot - can you please give this PR a quick look (early next week would be awesome). I had tagged mati but realised he is on holiday. |
tbuchaillot
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.