-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-1590] Tyk Operator : API Level Global Features (Draft) #5175
Conversation
PR Reviewer Guide 🔍(Review updated until commit 496e273)
|
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -0,0 +1,344 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcs3spp Can I please ask why we have a new file for this capability and not updating an existing doc?
Also the page explains about looping using the operator while the word operator is not any of the titles. Why aren't we following the structure we had in other pages I saw (e.g. allowlist, virtual endpoint etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if this is really needed or can be done in the same way as others.
If we still keep it this way (after we understand the reason), we'll need a link from the other looping page to this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caroltyk what was the reason for targeting the internal looping example within Tyk Operators docs?
Are you ok with that content being moved to this page as an additional section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcs3spp looks like this is a looping page that doesn't mention looping https://tyk.io/docs/product-stack/tyk-gateway/middleware/internal-endpoint-middleware/ - maybe we want to add the content here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dcs3spp Since operator has special feature to allow user to reference rewrite URL using k8s name and namespace, we can keep this page where it is. We can add a link from https://deploy-preview-5175--tyk-docs.netlify.app/docs/nightly/product-stack/tyk-gateway/middleware/url-rewrite-tyk-classic/ to Operator's looping page as cross reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caroltyk I have updated with link from URL-Rewrite. Should there be a link updated from the Tyk Classic page of the section highlighted by @letzya https://tyk.io/docs/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-classic/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think looping example should be added there because it doesn't do looping, just blocking external access.
Btw, we have Internal Endpoint example on another PR too: https://deploy-preview-5258--tyk-docs.netlify.app/docs/nightly/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-classic/#tyk-operator
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/plugins/supported-languages/rich-plugins/grpc/write-grpc-plugin.md
Outdated
Show resolved
Hide resolved
…/write-grpc-plugin.md Co-authored-by: caroltyk <[email protected]>
@@ -15,6 +15,8 @@ If you want to use dynamic data from context variables, you must [enable]({{< re | |||
|
|||
If you're using the newer Tyk OAS APIs, then check out [this]({{< ref "/product-stack/tyk-gateway/middleware/url-rewrite-tyk-oas" >}}) page. | |||
|
|||
If you're using Tyk Operator, then check out [this]({{< ref "/product-stack/tyk-operator/advanced-configurations/internal-looping" >}}) page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to create a subheading at the end of the page for Tyk Operator and add the link there, so that users easily know they can configure this via Operator from the navigation menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @caroltyk I have updated to included subheading for Tyk Operator that includes the link
tyk-docs/content/product-stack/tyk-operator/advanced-configurations/internal-looping.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-operator/advanced-configurations/internal-looping.md
Outdated
Show resolved
Hide resolved
…tions/internal-looping.md Co-authored-by: caroltyk <[email protected]>
…tions/internal-looping.md Co-authored-by: caroltyk <[email protected]>
Thanks @caroltyk I have added example for do not track middleware. Should we add an example to that section also for setting do not track middleware for a specific endpoint? |
Do not track middleware example is added here: https://deploy-preview-5258--tyk-docs.netlify.app/docs/nightly/product-stack/tyk-gateway/middleware/do-not-track-tyk-classic/#tyk-operator |
Thanks @caroltyk I have added the example to https://deploy-preview-5175--tyk-docs.netlify.app/docs/nightly/product-stack/tyk-gateway/middleware/do-not-track-tyk-classic |
Persistent review updated to latest commit 496e273 |
PR Code Suggestions ✨Latest suggestions up to 496e273
|
Add API level global features provided in Google spreadsheet --------- Co-authored-by: Simon Pears <[email protected]> Co-authored-by: caroltyk <[email protected]>
User description
For internal users - Please add a Jira DX PR ticket to the subject!
DX-1590
Preview Link
preview - link to internal looping from URLRewrite page
preview - internal looping
preview - request header transformations
preview - response header transformations
preview - segment tags
preview - CORS
preview - gRPC
preview - Javascript
preview - Custom Plugin Analytics
preview - Round Robin Load Balancing
preview - Do not track middleware
preview - Analytics tagging
Description
Add examples for API level global features. The PR includes all examples except for Config Data which had target page marked as missing. The config data example is included in virtual endpoints.
Question for reviewers:
Is there a working example for Tyk Operator for configuring gRPC to use remote bundles? If plugin bundles are not supported in Tyk Operator then content in PR should be updated to state this. There is an example in this PR for gRPC with custom middleware manifest in API definition but not an example that links to the bundled zip file containing the manifest.
Should the following API global features be included with examples?
Screenshots (if appropriate)
Checklist
master
.PR Type
Documentation
Description
Changes walkthrough 📝
13 files
with-tyk-multi-cloud.md
Add Tyk Operator API Shard Tagging Example
tyk-docs/content/advanced-configuration/manage-multiple-environments/with-tyk-multi-cloud.md
rate-limiting.md
Add Tyk Operator Global Rate Limiting Example
tyk-docs/content/basic-config-and-security/control-limit-traffic/rate-limiting.md
load-balancing.md
Configure Load Balancing with Tyk Operator
tyk-docs/content/planning-for-production/ensure-high-availability/load-balancing.md
analytics-plugins.md
Add Tyk Operator Analytics Plugin Configuration
tyk-docs/content/plugins/plugin-types/analytics-plugins.md
write-grpc-plugin.md
Configure gRPC Plugin Hooks with Tyk Operator
tyk-docs/content/plugins/supported-languages/rich-plugins/grpc/write-grpc-plugin.md
do-not-track-tyk-classic.md
Enhance Middleware Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/do-not-track-tyk-classic.md
request-header-tyk-classic.md
Add Request Header Transformation Example for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Operator.
url-rewrite-tyk-classic.md
Reference Internal Looping Examples
tyk-docs/content/product-stack/tyk-gateway/middleware/url-rewrite-tyk-classic.md
custom-plugins.md
Document Custom Plugin Configuration with Tyk Operator
tyk-docs/content/product-stack/tyk-operator/advanced-configurations/custom-plugins.md
Operator.
internal-looping.md
Document Internal Looping with Tyk Operator
tyk-docs/content/product-stack/tyk-operator/advanced-configurations/internal-looping.md
Operator.
configurations.
api-definition.md
Update JavaScript Plugin Reference Link
tyk-docs/content/product-stack/tyk-operator/reference/api-definition.md
cors.md
Add CORS Configuration Example for Tyk Operator
tyk-docs/content/tyk-apis/tyk-gateway-api/api-definition-objects/cors.md
custom-analytics.md
Setup Tag Headers with Tyk Operator
tyk-docs/content/tyk-apis/tyk-gateway-api/api-definition-objects/custom-analytics.md
1 files
response-header-tyk-classic.md
Minor Formatting Adjustment
tyk-docs/content/product-stack/tyk-gateway/middleware/response-header-tyk-classic.md
1 files
menu.yaml
Update Menu with New Documentation Entries
tyk-docs/data/menu.yaml