-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-1591] Integrate Tyk Operator Endpoint Level Features (Draft) #5258
Conversation
…body-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
…header-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
…header-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
…size-limit-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
…-body-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
…-body-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
…-body-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
…-body-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
…-header-tyk-classic.md Co-authored-by: Burak Sekili <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thank you!!
@dcs3spp, added previous response from @buraksekili here too
Advanced trigger is marked as not supported
act_on is part of the API Definition (reference, here) and to be honest i am not sure what feature it enables. So, please keep it in the API Definition CRD as well.
I've tested with following manifest: API level Request size limit:
API Response Header Transform
@komalsukhani can you confirm?
It might be missing in original gateway docs. |
@caroltyk for enforced t/o, maybe we can update CR according to API Designer example so that all samples are aligned across platforms - we do not need to create a new one though. Our current sample combines enforced timeouts with circuit breakers which is still valid for enforced t/o |
Thanks @caroltyk I have integrated the response header transform and request size limit examples. For the response header transform should there also be an example for GW versions < 5.3.0 similar to the endpoint level examples on the same page? |
@caroltyk Advanced triggers for URL rewrites have been used in the internal looping example, in this section for the API entry point. Should the status of Advanced triggers for URL rewrites be changed in the table to mark them as supported and an example added to this page or alternatively a link added to internal looping example? |
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
add planned endpoint examples included in Google spreadsheet --------- Co-authored-by: Simon Pears <[email protected]> Co-authored-by: Burak Sekili <[email protected]>
User description
For internal users - Please add a Jira DX PR ticket to the subject!
DX-1591
Preview Link
preview - allow list
preview - block list
preview - circuit breaker
preview - do not track
preview - endpoint cache
preview - enforced timeout
preview - ignore
preview - internal endpoint
preview - mock response
preview - request body transform
preview - request header transform
preview - request method transform
preview - request size limit
preview - response body transform
preview - response header transform
preview - url rewrite
preview - validate request
preview - virtual endpoint
Description
Integrate Endpoint Level Tyk Operator features, adding examples for endpoint level features.
Question for reviewers
Is threshold in the example invalid for Dashboard API and is the enforced timeout needed? Is there no action needed for this?
Should there be an advanced trigger example in this page also? Currently only have examples for URL Rewrite triggers in Tyk Operator GHub internal looping? See here It is marked as unsupported feature but internal looping examples uses it
What is act_on field in example and should it be removed from the examples it appears in if not needed? Answered in comments, it should be retained.
Should there be corresponding API level examples for Request size limit & Response header transforms?
Added in API Global features PR
Is there a typo in path of virtual section in the yaml example, should the path be /virtual instead of virtual?
Fixed
In cache options configuration object in caching example there are options to configure the cache_response_codes and cache headers (commented). However these are not present in simple caching options for GW. Missing in GW docs?
Screenshots (if appropriate)
Checklist
master
.PR Type
documentation
Description
Changes walkthrough 📝
19 files
allow-list-tyk-classic.md
Add Allow List Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/allow-list-tyk-classic.md
block-list-tyk-classic.md
Add Block List Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/block-list-tyk-classic.md
circuit-breaker-tyk-classic.md
Add Circuit Breaker Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/circuit-breaker-tyk-classic.md
do-not-track-tyk-classic.md
Add Do Not Track Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/do-not-track-tyk-classic.md
endpoint-cache-tyk-classic.md
Add Endpoint Cache Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/endpoint-cache-tyk-classic.md
enforced-timeout-tyk-classic.md
Add Enforced Timeout Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-classic.md
ignore-tyk-classic.md
Add Ignore Authentication Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/ignore-tyk-classic.md
Operator.
internal-endpoint-tyk-classic.md
Add Internal Endpoint Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-classic.md
Operator.
mock-response-tyk-classic.md
Add Mock Response Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/mock-response-tyk-classic.md
Operator.
request-body-tyk-classic.md
Add Request Body Transform Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/request-body-tyk-classic.md
request-header-tyk-classic.md
Add Request Header Transform Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Operator.
request-method-tyk-classic.md
Add Request Method Transform Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-classic.md
Operator.
request-size-limit-tyk-classic.md
Add Request Size Limit Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/request-size-limit-tyk-classic.md
response-body-tyk-classic.md
Add Response Body Transform Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/response-body-tyk-classic.md
response-header-tyk-classic.md
Add Response Header Transform Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/response-header-tyk-classic.md
Operator.
url-rewrite-tyk-classic.md
Add URL Rewriter Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/url-rewrite-tyk-classic.md
validate-request-tyk-classic.md
Add Validate Request Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/validate-request-tyk-classic.md
Operator.
virtual-endpoint-tyk-classic.md
Add Virtual Endpoint Configuration for Tyk Operator
tyk-docs/content/product-stack/tyk-gateway/middleware/virtual-endpoint-tyk-classic.md
api-definition.md
Update Middleware Feature Links and Descriptions
tyk-docs/content/product-stack/tyk-operator/reference/api-definition.md