-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-13731] Fixes bundle plugin sub-directory problem. #5831
base: master
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 61 and 62 made sense when the bundles where in subdirectories, they don't when they're not.
Also their reference to Python doesn't make sense when the default in the docs is golang. I don't think a language needs to be mentioned, they're just "plugin source files"
An example manifest to go with each example directory would make things much more clear. There's an example manifest at https://tyk.io/docs/plugins/how-to-serve-plugins/plugin-bundles/#manifest which could be used as a starting place
...docs/content/product-stack/tyk-gateway/advanced-configurations/plugins/bundles/bundle-cli.md
Outdated
Show resolved
Hide resolved
...docs/content/product-stack/tyk-gateway/advanced-configurations/plugins/bundles/bundle-cli.md
Outdated
Show resolved
Hide resolved
…ions/plugins/bundles/bundle-cli.md Co-authored-by: Tit Petric <[email protected]>
…ions/plugins/bundles/bundle-cli.md Co-authored-by: Tit Petric <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A huge improvement, thanks
User description
For internal users - Please add a Jira DX PR ticket to the subject!
Preview Link
https://deploy-preview-5831--tyk-docs.netlify.app/docs/nightly/product-stack/tyk-gateway/advanced-configurations/plugins/bundles/bundle-cli
Description
Screenshots (if appropriate)
Checklist
master
.PR Type
Documentation
Description
bundle-directory
for plugin bundles.bundle-directory
.Changes walkthrough 📝
bundle-cli.md
Clarified subdirectory usage and updated examples in bundle
documentation
tyk-docs/content/product-stack/tyk-gateway/advanced-configurations/plugins/bundles/bundle-cli.md
supported in the
bundle-directory
.Python bundles to remove subdirectories.