Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging to release-5.7: Fix typo in JSON (#5875) #5876

Conversation

buger
Copy link
Member

@buger buger commented Jan 8, 2025

User description

Fix typo in JSON (#5875)


PR Type

Documentation


Description

  • Fixed a JSON formatting typo in documentation.

  • Improved clarity of Allow List middleware example.


Changes walkthrough 📝

Relevant files
Documentation
allow-list-tyk-classic.md
Fixed JSON formatting typo in documentation                           

tyk-docs/content/product-stack/tyk-gateway/middleware/allow-list-tyk-classic.md

  • Corrected a JSON formatting typo by adding a missing comma.
  • Improved the accuracy of the JSON example for better understanding.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    (cherry picked from commit 20f0a9d)
    @buger buger enabled auto-merge (squash) January 8, 2025 05:15
    Copy link
    Contributor

    github-actions bot commented Jan 8, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    5875 - Fully compliant

    Fully compliant requirements:

    • Fix a typo in the JSON example in the Allow List middleware documentation.
    • Ensure the JSON example is accurate and clear.

    Not compliant requirements:
    []

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    github-actions bot commented Jan 8, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link

    netlify bot commented Jan 8, 2025

    PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit 1968b37
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/677e09e3efa8310008d20747
    😎 Deploy Preview https://deploy-preview-5876--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @buger buger merged commit 723976b into release-5.7 Jan 8, 2025
    9 checks passed
    @buger buger deleted the merge/release-5.7/20f0a9d3a90c9401bb698769b53133fcf0fea70c branch January 8, 2025 05:17
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants