Added card component #364
Added card component #364
Conversation
✅ Deploy Preview for nifty-johnson-6002dd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/components/Card/sass/Card.scss
Outdated
| &__title { | ||
| font-family: $font-inter-bold; | ||
| font-size: $lg-font-size; | ||
| display: box; |
There was a problem hiding this comment.
I had to look for the box value but it doesn't seem to exist. I think it should be display: flex; instead.
There was a problem hiding this comment.
src/components/Card/sass/Card.scss
Outdated
| font-family: $font-inter-bold; | ||
| font-size: $lg-font-size; | ||
| display: box; | ||
| box-orient: vertical; |
There was a problem hiding this comment.
The same for the box-orient property. It doesn't seem to be part of the standard, it looks like it is deprecated. It probably should be flex-direction: column; instead.
There was a problem hiding this comment.
| display: -webkit-box; | ||
| -webkit-box-orient: vertical; |
There was a problem hiding this comment.
These seem to be non standard and won't work the same in all the browsers. They should probably be replaced with flex css properties.
There was a problem hiding this comment.
https://css-tricks.com/almanac/properties/l/line-clamp/ was trying to use this property, which allows me to check how many lines are visible from a text.
|
No description provided.