Merging to release-5.6: TT-13130 update gorpc version (#6644) #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-13130" title="TT-13130" target="_blank">TT-13130</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Tyk Cloud: Panic appears when a user tried to deploy GW before Control Plane is in deployed state </td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20Re_open%20ORDER%20BY%20created%20DESC" title="Re_open">Re_open</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20QA_Fail%20ORDER%20BY%20created%20DESC" title="QA_Fail">QA_Fail</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description <!-- Describe your changes in detail --> ## Related Issue TT-13130 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Updated the `gorpc` library to a newer version in `go.mod` and `go.sum`. - Modified the RPC client connection handling by replacing `ConnectionDialingWG.Wait()` with `WaitForConnection()`, improving the connection logic. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>rpc_client.go</strong><dd><code>Update connection handling in RPC client</code> </dd></summary> <hr> rpc/rpc_client.go <li>Replaced <code>ConnectionDialingWG.Wait()</code> with <code>WaitForConnection()</code>.<br> <li> Improved connection handling logic.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6644/files#diff-3b88914c99bb9418e44e6389ce73579843562e8900730b380d7fff2e95c51033">+1/-1</a> </td> </tr> </table></td></tr><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Update gorpc dependency version in go.mod</code> </dd></summary> <hr> go.mod - Updated `gorpc` dependency version. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6644/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+1/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>Update go.sum with new gorpc checksums</code> </dd></summary> <hr> go.sum - Added new checksum entries for updated `gorpc` version. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6644/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+2/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information --------- Co-authored-by: sredny buitrago <[email protected]> (cherry picked from commit 8f37f4b)
|
API Changes no api changes detected |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
sredxny
approved these changes
Oct 16, 2024
lghiur
deleted the
merge/release-5.6/8f37f4bc9531e93a809735a0783fe8e11321d858
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
TT-13130 update gorpc version (#6644)
User description
TT-13130
Description
Related Issue
TT-13130
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
functionality to change)
coverage to functionality)
Checklist
why it's required
explained why
PR Type
Bug fix, Enhancement
Description
gorpclibrary to a newer version ingo.modandgo.sum.ConnectionDialingWG.Wait()withWaitForConnection(), improving theconnection logic.
Changes walkthrough 📝
rpc_client.go
Update connection handling in RPC clientrpc/rpc_client.go
ConnectionDialingWG.Wait()withWaitForConnection().go.mod
Update gorpc dependency version in go.modgo.mod
gorpcdependency version.go.sum
Update go.sum with new gorpc checksumsgo.sum
gorpcversion.Co-authored-by: sredny buitrago [email protected]
PR Type
Bug fix, Enhancement
Description
gorpclibrary to a newer version ingo.modandgo.sum.ConnectionDialingWG.Wait()withWaitForConnection(), improving the connection logic.Changes walkthrough 📝
rpc_client.go
Update connection handling in RPC clientrpc/rpc_client.go
ConnectionDialingWG.Wait()withWaitForConnection().go.mod
Update gorpc dependency version in go.modgo.mod
gorpcdependency version.go.sum
Update go.sum with new gorpc checksumsgo.sum
gorpcversion.