feat: Add linking tests #9
Conversation
msujew
force-pushed
the
feature/langium-project
branch
from
aaae68e to
183a00e
Compare
| describe('Declarations and labels', async () => { | ||
| const text = ` | ||
| Control: procedure options(main); | ||
| call <|>A('ok'); // invoke the 'A' subroutine |
There was a problem hiding this comment.
I would write something like ok! with an extra char, otherwise the compiler complains about the type, since it's expecting a char(3).
There was a problem hiding this comment.
Ok, good catch! Should we also change this string as well in the parsing tests? https://github.com/TypeFox/zowe-pli-language-support/blob/feature/langium-project/packages/language/test/parsing.test.ts#L93
|
|
||
| describe('Qualified names', async () => { | ||
| const text = ` | ||
| 0DCL 1 <|TWO_DIM_TABLE|>, |
There was a problem hiding this comment.
Like the prior program I would wrap this with a main procedure, otherwise the compiler won't take it. The 0 before the DCL usage is also optional in this case, since that's for the pre-processor.
There was a problem hiding this comment.
I have done similarly to the parsing tests, where I wrap the test programs with a main procedure: https://github.com/TypeFox/zowe-pli-language-support/pull/9/files#diff-6e9ceab833d04f3a6b234d1519334012358bc20e2fcee996a49f34618061f6a1R28
Will this be sufficient?
msujew
force-pushed
the
feature/langium-project
branch
2 times, most recently
from
91e9352 to
4e07d32
Compare
didrikmunther
force-pushed
the
feature/didrik/add-linking-tests
branch
from
970b4de to
c4c7842
Compare
No description provided.