Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added example usage for multicollinearity #35

Merged
merged 4 commits into from
Jan 26, 2025

Conversation

awlh18
Copy link
Collaborator

@awlh18 awlh18 commented Jan 25, 2025

No description provided.

@awlh18 awlh18 added the ready for review For code and issues that are ready to be reviewed label Jan 25, 2025
@awlh18 awlh18 added this to the milestone3 milestone Jan 25, 2025
@awlh18 awlh18 linked an issue Jan 25, 2025 that may be closed by this pull request
Copy link
Collaborator

@merari95 merari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your documentation is clear. I recommend adding an interpretation of the results from your example.

For instance, you could list the features with high VIFs. Additionally, consider briefly concluding how check_multicollinearity helps diagnose multicollinearity and guides decisions to refine the regression model (i.e. dropping the features).

Copy link
Collaborator

@Psingh238 Psingh238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the necessary changes to conform to Python styling conventions and to render the plot correctly in the notebook.

docs/example.ipynb Outdated Show resolved Hide resolved
docs/example.ipynb Outdated Show resolved Hide resolved
docs/example.ipynb Outdated Show resolved Hide resolved
docs/example.ipynb Show resolved Hide resolved
@awlh18
Copy link
Collaborator Author

awlh18 commented Jan 26, 2025

addressed comments in the latest commit

@Psingh238
Copy link
Collaborator

Changes approved and merge conflict has been resolved.

@Psingh238 Psingh238 merged commit 1f9f56e into main Jan 26, 2025
3 of 4 checks passed
@Psingh238 Psingh238 deleted the 34-create_multicollinearity_usage_example branch January 26, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review For code and issues that are ready to be reviewed
Projects
Development

Successfully merging this pull request may close these issues.

Create_multicollinearity_usage_example
3 participants