Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursive check for build gradle arch #145

Merged
merged 3 commits into from
Jun 26, 2019

Conversation

kevinchern
Copy link
Collaborator

for #144

@alexandrebouchard
Copy link
Contributor

Thanks a lot!
ls options tend to not be super portable, I was wondering if a pure Java version of this patch would be easy to do?

@kevinchern
Copy link
Collaborator Author

kevinchern commented Jun 26, 2019

Oh right that's a good point, I'll give it a try tomorrow if there are not other more urgent tasks*

@kevinchern
Copy link
Collaborator Author

@alexandrebouchard the latest commit should work 05c337d

@alexandrebouchard
Copy link
Contributor

alexandrebouchard commented Jun 26, 2019

Looks good thanks!

The fix is great but I thought of some other potential related problems so let's chat this afternoon.

  • what if blang is called say at / - this will get really slow
  • what if called in say blangSDK/src, will still run into issues
  • in some sense generally it is error prone to ask user to be in a specific directory when running something

Potential idea: move to a more git-like style

  • ask user to add --init first time: only if that flag is present then we do the recursive checks
  • when init is not there, we just look for .blangcompilation
  • optionally, as bonus we could allow the blang command to be ran in any subdirectory of the blang project

This way if user does blang --help we are sure something crazy will not happen, and we also minimize the chances the user calls blang in the wrong folder

I guess we could also just do a special case for "blang --help" the git-style solution will need that anyways..

Let's chat soon

@alexandrebouchard alexandrebouchard merged commit 57752b5 into UBC-Stat-ML:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants