Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chemistry solver update #532

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Chemistry solver update #532

merged 1 commit into from
Dec 9, 2024

Conversation

kolosret
Copy link
Contributor

Updated error handling in ZeroRK source calculator, updated defaults for loadbalancing and tolerances. Version bump to 0.12.35

@kolosret kolosret requested a review from klbudzin November 27, 2024 18:14
@kolosret
Updated error handling in ZeroRK source calculator, updated defaults …
79f66c6 
…for loadbalancing and tolerances. Version bump to 0.12.35
klbudzin
klbudzin approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@klbudzin klbudzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I hope the retry stuff isn't needed if ZeroRk is already doing this itself.

@klbudzin klbudzin merged commit a230510 into UBCHREST:main Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klbudzin klbudzin klbudzin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolosret @klbudzin