commiting stock mech files (for later use) and make_metadata.py #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(a utility for building meta-data files in the standard case)
mmcgurn
requested changes
Jun 30, 2023
| cfg['name']=os.path.basename(args.model_folder) | ||
| cfg['mechanism']=os.path.basename(args.mech_filename) | ||
|
|
||
| os.system(f'cp {args.mech_filename} {args.model_folder}/.') |
There was a problem hiding this comment.
I believe we missing some of the required metadata. I think we should wait until we know that this metadata script works. For stuff like this we should add documentation to the repo.
| @@ -0,0 +1,1817 @@ | |||
| description: |- | |||
There was a problem hiding this comment.
I do not believe we should commit these. They can be/will be specific for each model (such as modifications of species order or rates).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_metadata.py: a utility for building meta-data files in the standard case
stock mech files: easy to reference for new models
These were the only things from my personal repo that seemed like they should be added apparently.