Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8 and clang-tidy linters #179

Merged
merged 18 commits into from
Oct 18, 2023
Merged

Update flake8 and clang-tidy linters #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a1f0b9b
Copy ament clang tidy source code
patrick-5546 Oct 18, 2023
23f3b4b
Add flake8 file
patrick-5546 Oct 18, 2023
4fc0b42
Make compatible with black
patrick-5546 Oct 18, 2023
175156e
Use flake8 config file
patrick-5546 Oct 18, 2023
46b1bdf
Format clang-tidy
patrick-5546 Oct 18, 2023
708edbd
Move to clang-tidy directory
patrick-5546 Oct 18, 2023
1379420
Use it
patrick-5546 Oct 18, 2023
757f663
Specify compile.json
patrick-5546 Oct 18, 2023
d1b534b
Exclude files
patrick-5546 Oct 18, 2023
4b01a69
Update print statement
patrick-5546 Oct 18, 2023
c8ce5ea
Try reducing number of parallel jobs
patrick-5546 Oct 18, 2023
cdaf3b5
Settle on 8 parallel jobs
patrick-5546 Oct 18, 2023
63e596b
Properly exclude protobuf source files
hhenry01 Oct 18, 2023
33f6b3c
Only check end of file
patrick-5546 Oct 18, 2023
3b910fd
Test clang-tidy error
patrick-5546 Oct 18, 2023
e6de51b
Disable clang tidy during build
patrick-5546 Oct 18, 2023
3add9fa
Update comment
patrick-5546 Oct 18, 2023
8ffa29e
Revert test clang-tidy error
patrick-5546 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .devcontainer/config/sailbot_workspace.code-workspace
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,7 @@
// copy from https://github.com/ament/ament_lint/blob/humble/ament_flake8/ament_flake8/configuration/ament_flake8.ini
// except for import order style = google: use isort with black profile instead
"flake8.args": [
"--extend-ignore=B902,C816,D100,D101,D102,D103,D104,D105,D106,D107,D203,D212,D404,I202",
"--max-line-length=99",
"--show-source",
"--statistics",
"--config=${workspaceFolder:sailbot_workspace}/.flake8",
],
"flake8.interpreter": ["/usr/bin/python3"],
// formatter: black and isort extensions
Expand Down Expand Up @@ -372,7 +369,7 @@
"label": "clang-tidy",
"detail": "Run clang-tidy static analysis",
"type": "shell",
"command": "./run_clang-tidy.sh",
"command": "LOCAL_RUN=true .github/actions/clang-tidy/run.sh",
"problemMatcher": [],
"presentation": {
"panel": "dedicated",
Expand Down
6 changes: 6 additions & 0 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[flake8]
extend-ignore = B902,C816,D100,D101,D102,D103,D104,D105,D106,D107,D203,D212,D404,I202,E203
import-order-style = google
max-line-length = 99
show-source = true
statistics = true
7 changes: 6 additions & 1 deletion .github/actions/ament-lint/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@ function lint {
LINTED_FILES=`eval ${FILE_SEARCH_CMD}`

if [[ ! -z ${LINTED_FILES} ]]; then
ament_${LINTER} ${LINTED_FILES}
if [[ ${LINTER} = "flake8" ]]; then
# use custom configuration file that is compatible with black formatter
ament_${LINTER} --config .flake8 ${LINTED_FILES}
else
ament_${LINTER} ${LINTED_FILES}
fi
else
warn "WARNING: No files found for ${LINTER}. Skipping ament_${LINTER}..."
fi
Expand Down
Loading