Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boat state update with new wind and current vectors #415

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Boat state update with new wind and current vectors #415

merged 4 commits into from
Aug 1, 2024

Conversation

alberto-escobar
Copy link
Contributor

Description

  • Generate new fluid vectors for wind and water by calling next method on respective fluid generator objects
  • Pass new fluid vectors into __boat_state through step method

Verification

  • No testing done, this will be tested through integration testing

@alberto-escobar alberto-escobar added enhancement New feature or request sim Boat Simulator team labels Jul 4, 2024
@alberto-escobar alberto-escobar self-assigned this Jul 4, 2024
@alberto-escobar alberto-escobar requested a review from eomielan as a code owner July 4, 2024 05:19
@alberto-escobar alberto-escobar linked an issue Jul 4, 2024 that may be closed by this pull request
Calculate physics engine data #401
Closed
eomielan
eomielan requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@eomielan eomielan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small comment.

src/boat_simulator/boat_simulator/nodes/physics_engine/physics_engine_node.py Outdated Show resolved Hide resolved
@alberto-escobar alberto-escobar enabled auto-merge (squash) August 1, 2024 03:14
@alberto-escobar alberto-escobar merged commit 28b34f1 into main Aug 1, 2024
11 checks passed
@alberto-escobar alberto-escobar deleted the alberto-escobar/401-calculate-physics-engine-data branch August 1, 2024 03:26
@alberto-escobar alberto-escobar linked an issue Sep 28, 2024 that may be closed by this pull request
Publish physics engine data #400
Open
@alberto-escobar alberto-escobar removed a link to an issue Sep 28, 2024
Publish physics engine data #400
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eomielan eomielan eomielan approved these changes

Assignees

@alberto-escobar alberto-escobar

Labels
enhancement New feature or request sim Boat Simulator team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculate physics engine data
2 participants
@alberto-escobar @eomielan