Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmer import speed up #165

Closed
wants to merge 1 commit into from
Closed

Symmer import speed up #165

wants to merge 1 commit into from

Conversation

MIWdlB
Copy link
Contributor

@MIWdlB MIWdlB commented Nov 2, 2023

Import was taking way too long

Screenshot from 2023-11-02 13-58-46

Quick check suggested that the biggest dependency was ray.

Each file only uses put, get, remote so import changed to specifically these.

Import is much faster as a result.

Screenshot from 2023-11-02 13-59-27

@MIWdlB MIWdlB added the bug Something isn't working label Nov 2, 2023
@MIWdlB MIWdlB requested a review from TimWeaving November 2, 2023 14:06
@MIWdlB MIWdlB self-assigned this Nov 2, 2023
@MIWdlB
Copy link
Contributor Author

MIWdlB commented Nov 6, 2023

@TimWeaving @AlexisRalli any reason the tests should be failing?

@AlexisRalli
Copy link
Collaborator

The issues in this pull request are being fixed in #166

@AlexisRalli AlexisRalli closed this Nov 6, 2023
@AlexisRalli AlexisRalli mentioned this pull request Nov 6, 2023
@TimWeaving TimWeaving deleted the speedy-import branch November 28, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants