Faster PauliwordOp.to_opemnfermion
#175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 75.78% 75.87% +0.09%
==========================================
Files 35 35
Lines 3936 3951 +15
==========================================
+ Hits 2983 2998 +15
Misses 953 953 ☔ View full report in Codecov by Sentry. |
|
Can probably be made a bit faster by converting the whole symplectic in a vectorised function but low priority to figure that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of the function used
symplectic_to_stringthen looped through the string.I've made a new function which amends
symplectic_to_stringdirectly so that this isn't necessary.Files changed
symmer/operators/utils.pysymmer/operators/base.pyLooks like a huge amount of change but its mostly linting (suggests that CICD is not working as intended). I can revert that if you'd rather.