Character rendering optimizations and off-by-one fix #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_burst_transfer). Fix an off-by-one error in lcd_fill_rectangle. Remove an unnecessary REG_SYNC from lcd_write_string.
|
No idea why this hasn't been merged in but this is a great contribution, @slyglif -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize lcd_write_char by rendering to a temporary memory buffer then using lcd_draw_image (and indirectly i2c_burst_transfer) instead of manually pushing a pixel at a time.
Remove an unnecessary REG_SYNC from lcd_write_string (it is handled indirectly by lcd_write_char).
Fix an off-by-one error in lcd_fill_rectangle (it effectively cropped the right most and bottom most pixels).