Initial PR for preschool update, adding historical years #429
Conversation
…accepted by the IPUMSR functions which are key to organizing the data in a way that makes the rest of the code work. Need to find a better way to make IPUMSR functions interact with AWS
|
@ridhi96 See my last commit. I'm having trouble with making aws.s3 compatible with IPUMSR. Let's chat about potential solutions. |
…g AWS storage within the IPUMS extract functions.
…not been released by Census
|
|
||
| *User note* This program depends on extracts from the IPUMS ACS API interface. If you are updating the extract please remember to update the note of the date of latest extract in the Housekeeping section of this program. | ||
|
|
||
| *Internal users* If you are an internal tester using the AWS feature of this program remember to enter the passkey into your environment using Sys.setenv(). Authentication steps are nicely explained in this [blog](https://www.gormanalysis.com/blog/connecting-to-aws-s3-with-r/). You will have to request access to the access key. |
There was a problem hiding this comment.
We should probably mention that the access key can be requested by contacting the AWS Admin. Don't want to point to internal resources at Urban but give internal users an idea where to look for it.
|
|
||
|
|
||
| # DO NOT PUSH YOUR API KEY. You only have to run this once and then comment it out as below. | ||
| #set_ipums_api_key("Your KEY", save = TRUE) |
There was a problem hiding this comment.
I think it's a little risky to ask the user to add in their key and then comment the code again. If they forget to remove the key after and just comment the code, it will still get pushed to GitHub. Maybe we can direct the user to this function and tell them to execute it in the console as part of set up.
There was a problem hiding this comment.
For external users I think there is low risk of this because they won't be pushing this back to GitHub. I see risk potentially for future metric leads but think it is fairly low.
|
|
||
| Date of IPUMS extract. Denote the latest date that the IPUMS extract was changed and pulled both for the overall data and the repweights. The recommended date notation format is "mm_dd_yy". | ||
|
|
||
| For internal reviewers, if you plan to utilize AWS keep this date as it was last enetered by the metric lead unless you intend to change the extract. |
|
|
||
| ```{r} | ||
|
|
||
| acs_surveys <- list(paste0("us", params$year, "c")) |
There was a problem hiding this comment.
It will be useful for future updates to mention that params$year needs to be updated in the YAML parameters at the top.
| @@ -653,7 +664,7 @@ metrics_education_all <- results_all_expand %>% | |||
| ### Write out intermediate data | |||
|
|
|||
There was a problem hiding this comment.
In a lot of places in this code file counties are mentioned (e.g. line 557, 587 etc.) when it should be places. Please check and update.
| toc_float: true | ||
| embed-resources: true | ||
| code-fold: show | ||
| format:html | ||
| execute: | ||
| warning: false | ||
| editor_options: | ||
| chunk_output_type: console | ||
| --- | ||
|
|
There was a problem hiding this comment.
I think it would be useful to explain at the top what the intent of this file and why we are generating place data like this.
08_education/preschool_county.qmd
Outdated
| ``` | ||
|
|
||
| Look at the distribution of survey samples in the data. The number of unique samples in the data should match the number of surveys selected in the `extract_ipums()` function above. | ||
| Look at the survey year of the IPUMS data. The survey should year should match what was selected in the `extract_ipums()` function above. |
There was a problem hiding this comment.
Typo here: "The survey should year should"
08_education/run_preschool_years.qmd
Outdated
|
|
||
| ## Render QMD Years | ||
|
|
||
| Select which years of new data you want to run the preschool place calculate file for. |
There was a problem hiding this comment.
I think this file generates county files too. Please add a short explanation of the purpose of this file so any future metric leads can figure out if they need to update this. Thanks!
There was a problem hiding this comment.
Hi @jwalsh28! Thank you for updating the reviewed files. When you changed the year to "2023", the graphs showing the prek_attendance metric in preschool_place.qmd and preschool_county.qmd files need to be updated to display the year "2023" as they still show "2021".
|
@ridhi96 I updated the graphics in the validity section to use the year in the Params argument, given how the program is set up this should always reflect the latest year. |
No description provided.