Update Redis and related #2430
Draft
Update Redis and related #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `Redis.current` is deprecated and so we replace it with the default connection to Redis.
Now that we've cleared the deprecated method call, these two gems can be updated. They have to go together because Sidekiq locks to Redis.
mec
force-pushed
the
chore/update-redis-and-related
branch
5 times, most recently
from
314de46
to
35279b6
Compare
We want to run Redis in CI rather than rely on the fake redis gem. We also want the major version of Redis to match that in production (7) locally and in CI.
We have Redis locally and in CI so we don't need to fake it.
mec
force-pushed
the
chore/update-redis-and-related
branch
from
35279b6
to
fc342d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP waiting on others work to be merged.