-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial Threat Modelling document #274
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work so far. Most of my comments and suggestions are just minor improvements to spelling, grammar and structure.
software-engineering-policies/SecureDevelopment/SecureDevelopmentPolicy.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ollie Tjornelund <[email protected]>
Co-authored-by: Ollie Tjornelund <[email protected]>
|
||
Depending on the stage of the project, facilitation can be handled in two ways: | ||
|
||
- Early project – Facilitated by Security personnel (Principals, Lead Tech, ITSO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we saying that a threat modelling session at the start of a project needs to have Principals, leads, and ITSO in it? Usually how it works at the moment the team does the threat modelling session among themselves and then meets with ITSO to discuss the project and what had been identified and mitigations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To bring our conversation here, the ideal would be what is laid out in this document as you can build up your documentation from the early stages. It also allows for intervention at the design stage when looking from the outside in on the project. Obviously an ideal and something we can work towards.
|
||
Depending on the stage of the project, facilitation can be handled in two ways: | ||
|
||
- Early project – Facilitated by Security personnel (Principals, Lead Tech, ITSO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is STRIDE done at the start of project? The gov link suggested it would be run by a PM or the secuirty org, with the relevent expertise from devs, devOps, hardware admin, net admin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just been conversing with Dave Tilsley on this and at the start of the project (before any code is written) the ideal would be to have a data flow diagram and relevant people present (customers, user researchers/designers, security, devs, operations) so that a fluent discussion can be had about the initial design. Then we can move onto a more technical TM session as described above before being a little more hands off. STRIDE is how we categorise the things we find so it will be done all the way through, its just who is involved at what point may change.
What has changed
Why has this changed?