CSL-87: 1.15 CD What trading reasons does this site need a licence for? #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add selection options data
Added unit tests
findDataLabelByValue() -> findArrayItemByValue()
And other misc added lines
jamiecarterHO
requested review from
dk4g,
RobertMcCann and
vinodhasamiyappanHO
dk4g
reviewed
Feb 10, 2025
apps/controlled-drugs/index.js
Outdated
| ], | ||
| titleField: 'trading-reasons', | ||
| addStep: 'trading-reasons', | ||
| continueOnEdit: false, |
There was a problem hiding this comment.
continueOnEdit is redundant here
utils/index.js
Outdated
Comment on lines
88
to
90
| * Using the form select value in a data array of items containing a value property | ||
| * Finds and returns the first matching array item from the array. | ||
| * From the found item other properties such as 'label' can be extracted. |
There was a problem hiding this comment.
Suggested change
| * Using the form select value in a data array of items containing a value property | |
| * Finds and returns the first matching array item from the array. | |
| * From the found item other properties such as 'label' can be extracted. | |
| * Finds and returns the first matching item from an array of objects based on a given value. | |
| * The objects in the array should contain a 'value' property, and optionally other properties such as 'label'. |
utils/index.js
Outdated
Comment on lines
92
to
94
| * @param {array} data - A json or js formatted array of objects each containing a label and value property. | ||
| * @param {string} valueToFind - The form value of the selected item to find in the array 'data'. | ||
| * @returns {object|undefined} - Containing all the details of the found item. Undefined if no item was found. |
There was a problem hiding this comment.
Suggested change
| * @param {array} data - A json or js formatted array of objects each containing a label and value property. | |
| * @param {string} valueToFind - The form value of the selected item to find in the array 'data'. | |
| * @returns {object|undefined} - Containing all the details of the found item. Undefined if no item was found. | |
| * @param {array} data - An array of objects, each containing at least a 'value' property. | |
| * @param {string} valueToFind - The value to search for in the array. | |
| * @returns {object|undefined} - The first object that matches the given value, or undefined if no match is found. |
| "specify-trading-reasons": { | ||
| "header": "Specify your trading reason" | ||
| "header": "Summary of trading reasons", | ||
| "add-another": "Add another", |
There was a problem hiding this comment.
translation from buttons.json can be reused
"add-another": "Add another"
'change' is used in the final summary, using same name for all summary change buttons avoids fallback to HOF and is slightly safer
dk4g
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
CSL-87 Adds trading reasons aggregator loop to the controlled drugs form
Summary page aggregates and parses options added via:
Behaviour around summary routing is copied from the already existent substances-summary.
Anything Else? (optional)
refactored earlier
findChemical(value: string)utility tofindArrayItemByValue(data: array, value: string)to allow it to be dynamic when finding an item in arrayarrayby itsvalueprop (with array data structures assumed to have one).Updated tests and usage of
findChemical()in the precursor chemicals form to use new function.Made final summary page for controlled drugs a full width page
Check list