Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSL-86: 1.14 CD - Upload company registration certificate #63

Merged
merged 10 commits into from
Feb 12, 2025
Merged

Conversation

dk4g
Copy link
Collaborator

@dk4g dk4g commented Feb 7, 2025

What?

CSL-86 1.14 CD - Upload company registration certificate

In addition, conditional logic has been added to skip the step and hide the field on the Summary page if the user started from the "Existing licensee renew/change existing site" route.

Anything Else? (optional)

  • Refactored file upload template for easy reuse across multiple forms
  • Removed duplicate header on CD /who-witnesses-destruction-of-drugs step
  • Removed duplicate header on CD /regulatory-and-compliance-dbs-updates step
  • Title has been changed to match the heading on PC /upload-companies-house-evidence step
  • Added per conditions to all the fields for responsible witnessing destruction of drugs
  • Page title and heading have been changed on CD /regulatory-and-compliance-dbs-updates step

Check list

  • I have reviewed my own pull request
  • I have written tests (if relevant)

Copy link
Contributor

@jamiecarterHO jamiecarterHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@jamiecarterHO jamiecarterHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates

@dk4g dk4g merged commit 2897296 into master Feb 12, 2025
2 checks passed
@dk4g dk4g deleted the CSL-86 branch February 12, 2025 11:05
@vinodhasamiyappanHO vinodhasamiyappanHO restored the CSL-86 branch February 13, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants