-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSL-139: Add kube files for html-pdf-converter and hof-rds-api compon… #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents * html-pdf microservice is used to convert submitted form data to PDF, which is then sent to the iCasework system and attached to the user's confirmation email. * hof rds api is used to communicate with AWS RDS instances to store and retrieve data. * Any unused Pipeline steps are removed
jamiecarterHO
requested changes
Feb 11, 2025
* Ingress removed for data-service micorservice which mostly uses Service for communication * SKIP email removed which is not required * Exclude S3 bucket secret ref from app deployment.yaml * S3 bucket secret names updated to use s3-bucket, same for all services
* html-pdf-converter, data-service and filevault are now set to 2 replicas in production * We dont have HPA enabled hence team decided to have 2 replicas
* We need these to be included in deploy scripts to enable deployment with Drone
* Adds html-pdf and hof-rds-api deployments to Branch env * Included in deploy.sh scripts
dk4g
approved these changes
Feb 12, 2025
jamiecarterHO
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing?
Will be tested in Branch followed by UAT, Stage and Prod
Screenshots (optional)
Anything Else? (optional)
Check list