Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPP-49 Upload EU Passport Page #62

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

vivekkumar-ho
Copy link
Contributor

@vivekkumar-ho vivekkumar-ho commented Feb 5, 2025

What?

EPP-49 - New & Renew - Create a UPLOAD PASSPORT page

Why?

  • File upload page has been created for EU passport

How?

  • Added custom html page
  • errors and config is defined

Testing?

Local and branch testing

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@vivekkumar-ho vivekkumar-ho self-assigned this Feb 5, 2025
@vivekkumar-ho vivekkumar-ho changed the title WIP: EPP-49 upload passport initial commit WIP: EPP-49 upload passport Feb 5, 2025
@vivekkumar-ho vivekkumar-ho changed the title WIP: EPP-49 upload passport EPP-49 Upload EU Passport Page Feb 7, 2025
Copy link
Contributor

@MikeMaratheftis MikeMaratheftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with that, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants