Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPP-45 Upload address proof page #63

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vivekkumar-ho
Copy link
Contributor

@vivekkumar-ho vivekkumar-ho commented Feb 5, 2025

What?

EPP-45 - New & Renew - Create a UPLOAD PROOF OF ADDRESS page

Why?

Created upload proof of address page so users can upload their proof of address

How?

Testing?

Local and branch testing

Screenshots (optional)

epp-epp-45-proof-of-address-page internal branch sas-notprod homeoffice gov uk_new-and-renew_upload-proof-address

Screenshot 2025-02-10 at 13 35 18

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@vivekkumar-ho vivekkumar-ho self-assigned this Feb 5, 2025
@vivekkumar-ho vivekkumar-ho changed the title WIP: EPP-45 initial commit WIP: EPP-45 Upload address proof Feb 5, 2025
@vivekkumar-ho vivekkumar-ho changed the title WIP: EPP-45 Upload address proof EPP-45 Upload address proof page Feb 10, 2025
Copy link
Contributor

@MikeMaratheftis MikeMaratheftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants