Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epp 103 upload (EU) passport #67

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

PaolaDMadd-Pro
Copy link
Contributor

@PaolaDMadd-Pro PaolaDMadd-Pro commented Feb 11, 2025

What?

add upload (EU) passport page as per jira ticket EPP-103

Why?

to allow user to upload other type of passport like EU, Switzerland, Norway, Iceland or Liechtenstein.

How?

configured the following files as follows:

  • add create html for upload passport
  • add content in pages.json
  • add section in summary-data-section
  • update index.js with the new page
  • add in validation.json and config.js max limit error message in case limit increase more than 1.
  • fixed some typos for British passport page

Testing?

manual test on local

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@PaolaDMadd-Pro PaolaDMadd-Pro force-pushed the EPP-103-upload-eu-passport branch 4 times, most recently from db95192 to 0105fce Compare February 12, 2025 11:09
@PaolaDMadd-Pro PaolaDMadd-Pro marked this pull request as ready for review February 12, 2025 11:10
@PaolaDMadd-Pro PaolaDMadd-Pro force-pushed the EPP-103-upload-eu-passport branch 2 times, most recently from 9d0972a to 69c8120 Compare February 12, 2025 13:59
Copy link
Contributor

@vivekkumar-ho vivekkumar-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@PaolaDMadd-Pro PaolaDMadd-Pro force-pushed the EPP-103-upload-eu-passport branch 2 times, most recently from 19c5669 to 71186ed Compare February 13, 2025 16:28
- add create html for upload passport
- add content in pages.json
- add section in summary-data-section
- update index.js with the new page
- add in validation.json and config.js max limit error message in case limit increase more than 1.
- fixed some typos for British passport page
@PaolaDMadd-Pro PaolaDMadd-Pro force-pushed the EPP-103-upload-eu-passport branch from 71186ed to cabe3ad Compare February 14, 2025 11:39
@PaolaDMadd-Pro PaolaDMadd-Pro merged commit ed4eb82 into master Feb 14, 2025
3 checks passed
@PaolaDMadd-Pro PaolaDMadd-Pro deleted the EPP-103-upload-eu-passport branch February 14, 2025 11:54
@PaolaDMadd-Pro PaolaDMadd-Pro restored the EPP-103-upload-eu-passport branch February 14, 2025 14:04
@PaolaDMadd-Pro PaolaDMadd-Pro deleted the EPP-103-upload-eu-passport branch February 14, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants