Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMB-35 Add Forms for Serious and irreversible harm section and implementations #78

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

TemitopeAyokuHO
Copy link
Contributor

##What
Add forms screens for the 'serious and irreversible harm' section, aligns with Figma designs IMB-35

##Why
As shown on Figma design, form should be implemented in same flow

##How

  • add form path in index.js to match with url provided figma design
  • add fields in each form in /fields/index.js file
  • add validation to all the fields in validation.js file
  • add HTML files and partial page to handle extra text content
    -add javascript and css file to control numbers of country add, once these limit is reached the 'Add another button will be hidden' . this logic is added to assets/index.js and scss. also add a behaviour to the behaviours/harm-country-repeater.js
  • add behaviour to control the form loop depends on numbers of countries selected this was implemented in behaviours/
    - harm-country-name.js
    - harm-country-form-loop
  • add a summary page to render all answered question and anwser by creating an addition Html page Views/harm-claim-summary

##Test
Tested locally (But a glitch is possible)

Copy link
Contributor

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The functionality still seems quite buggy particularly the delete functionality on the human-rights-summary page - it seems to be removing the last in the list regardless of which country I select for deletion..
  • Linting errors (all testing stages should be passing locally and in drone before you request a review)
  • the harm-claim-summary page does not match the figma
  • Title tab on harm-claim-summary page is empty
    I haven't reviewed any further yet as it seems there's still a bit of work to be done on this so I will move the ticket back to in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants