-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMB-35 Add Forms for Serious and irreversible harm section and implementations #78
Open
TemitopeAyokuHO
wants to merge
14
commits into
master
Choose a base branch
from
IMB-35
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78f2160
to
0732ea7
Compare
Rhodine-orleans-lindsay
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The functionality still seems quite buggy particularly the delete functionality on the human-rights-summary page - it seems to be removing the last in the list regardless of which country I select for deletion..
- Linting errors (all testing stages should be passing locally and in drone before you request a review)
- the harm-claim-summary page does not match the figma
- Title tab on harm-claim-summary page is empty
I haven't reviewed any further yet as it seems there's still a bit of work to be done on this so I will move the ticket back to in progress
0732ea7
to
165e8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##What
Add forms screens for the 'serious and irreversible harm' section, aligns with Figma designs IMB-35
##Why
As shown on Figma design, form should be implemented in same flow
##How
-add javascript and css file to control numbers of country add, once these limit is reached the 'Add another button will be hidden' . this logic is added to assets/index.js and scss. also add a behaviour to the behaviours/harm-country-repeater.js
- harm-country-name.js
- harm-country-form-loop
##Test
Tested locally (But a glitch is possible)