Enhancement - added URL validator #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@easternbloc @JoeChapman @gavboulton @HughePaul mind having a look? |
|
@joefitter I've added more test cases but 'something.com.' is failing. |
gavboulton
force-pushed
the
enhancement/add-url-validator-master
branch
from
6d98f32 to
a0011b4
Compare
HughePaul
reviewed
Mar 10, 2017
| @@ -20,6 +20,10 @@ module.exports = Validators = { | |||
| return value !== undefined && value !== ''; | |||
| }, | |||
|
|
|||
| url: function url(value) { | |||
| return value === '' || Validators.regex(value, /[-a-zA-Z0-9@:%._\+~#=]{2,256}\.[a-z]{2,6}\b[-a-zA-Z0-9@:%_\+~#?&//=]*$/); | |||
There was a problem hiding this comment.
Should this enforce an optional protocol part? at the moment any chars are allowed at the start as there is no ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a requirement for a URL validator in ROTM. This cannot be achieved by using a regex validator as it is an optional field.