#125 마이스페이스 공유 닉네임으로 변경 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choign3123
reviewed
Feb 16, 2024
| @@ -19,6 +19,8 @@ public class Alarm extends BaseEntity { | |||
|
|
|||
| private boolean isRead; | |||
|
|
|||
| private String sharedSpaceNickname; | |||
There was a problem hiding this comment.
이건 Space 또는 MemberSpace 엔티티를 FK로 연관관계 맺어서 설정할 수도 있을 것 같습니당! 그러면 객체조회가 가능해지니까요.
그렇지만 이건 저도 뭐가 더 나은지 정답을 모르겠어서, 지금도 문제없을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 PR 타입 (하나 이상 선택)
❗️ 관련 이슈 링크
close #125
📌 개요
🔁 변경 사항
📸 스크린샷
👀 기타 더 이야기해볼 점
✅ 체크 리스트