Sunt05/issue301 #356
Merged
Sunt05/issue301 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunt05
commented
Feb 3, 2025
sunt05
commented
- Introduce EmissionsMethod Enum to provide structured emissions calculation options
- Update ModelPhysics to use EmissionsMethod for more type-safe configuration
- Add docstring explaining the purpose of the new Enum
- Remove commented-out code related to emissions method validation
- Improve code formatting and consistency in the _config.py module
- Introduce new _config.py module with SUEWSConfig and init_config_from_yaml - Consolidate model parameter validation checks in ModelPhysics and SnowParams - Update __init__.py to expose new configuration-related functions - Add sample configuration file and update build configuration
- Remove debug/diagnostic bash command that was causing unnecessary delay - Comment out the 'sleep 5 && ls -l' run_command in the meson build configuration
- Update patch_supy_driver.py to improve file handling and error checking - Modify meson.build to adjust custom target command arguments - Add debug print statements in move_output_gen.py and patch_supy_driver.py - Simplify Makefile dev target by removing unnecessary cleanup steps
- Introduce EmissionsMethod Enum to provide structured emissions calculation options - Update ModelPhysics to use EmissionsMethod for more type-safe configuration - Add docstring explaining the purpose of the new Enum - Remove commented-out code related to emissions method validation - Improve code formatting and consistency in the _config.py module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.