generated from UNDP-Data/dv-ui-starter-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Frontend modified to adapt to api change, Authentication flow change, Add card to PDF feature, and CI/CD updates #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feat(util): handler now contains singing out and refreshing mechanisms * Feat(api): centralized all api calls to /api dir * Feat(lib): added qs library for query string configuration * Feat(types): added required types for new api calls * Feat(App): replaced and refactored api calls to centralized functions * Chore(Constants): cleaned up constants to use vite setup * Refactor(MainBody): refactored api calls to centralized functions * Refactor(HomePage): refactored api calls and choice type definition * Refactor(AdminPanel): replaced api calls with centralized functions * Refactor(MyDrafts): replaced api calls with centralized functions * Fix(SignalCardPage): added error handling * Refactor(TrendEntryFormEl): replaced api calls to centralized functions and updated choice types * Refactor(SignalEntryFormEl): replaced api calls with centralized functions and updated choice types * Refactor(components): updated choices objects according to new type definition * Refactor(AddSingalsModal): replaced api calls with centralized calls and updated choice types * Refactor(AddTrendsModal): replaced api calls to centralized function calls and updated choice types * Refactor(SingOutButton): replaced api call to centralized function calls and updated choice types * Refactor(SignUpButton): replaced api calls to centralized function calls * Refactor(AllSignals): replaced api calls to centralized function calls * Refactor(EditSignal): replaced api call to centralized function call * Refactor(SignalDetail): replaced api calls to centralized function calls and updated choice types * Refactor(AllTrends): replaced api calls to centralized function calls * Refactor(EditTrend): replaced api call to centralized function call * Refactor(TrendDetail): replaced api calls to centralized function calls and updated choice types * Feat(asset): added hero image for easier relative import * Refactor(auth): cleaned up authentication flow via use of interceptor * Fix(Types): added missing attributes to types * Fix(MainBody): added missing attributes to api function call * Fix(PdfPageDesign): improved error handling for edge cases * Fix(EntryForms): added required parameters to api function calls * Fix(EditSignal/Trend): read using read endpoints instead of search endpoints * Fix(AllSignals/Trends): added proper status to filter for search * Refactor(minor): moved platform config to public folder * Fix(constants): refactored constants for consistency * Refactor(AuthConfig): renamed and refactored for consistency and readability * Fix(types): added created by attribute to fix updating params * Fix(api_config): increased timeout for image uploads and refactored auth process * Feat(App): logs out automatically if token is expired * Fix(main): minor import fix * Fix(addModals): added essential params * Fix(minor): import naming change * Fix(entryFormEl): added proper params for update and image display * Refactor(ci/cd): removed unused env variables and added new conditional variables for different branches * Refactor(CI/CD): improved conditional env variables
* Feat(util): handler now contains singing out and refreshing mechanisms * Feat(api): centralized all api calls to /api dir * Feat(lib): added qs library for query string configuration * Feat(types): added required types for new api calls * Feat(App): replaced and refactored api calls to centralized functions * Chore(Constants): cleaned up constants to use vite setup * Refactor(MainBody): refactored api calls to centralized functions * Refactor(HomePage): refactored api calls and choice type definition * Refactor(AdminPanel): replaced api calls with centralized functions * Refactor(MyDrafts): replaced api calls with centralized functions * Fix(SignalCardPage): added error handling * Refactor(TrendEntryFormEl): replaced api calls to centralized functions and updated choice types * Refactor(SignalEntryFormEl): replaced api calls with centralized functions and updated choice types * Refactor(components): updated choices objects according to new type definition * Refactor(AddSingalsModal): replaced api calls with centralized calls and updated choice types * Refactor(AddTrendsModal): replaced api calls to centralized function calls and updated choice types * Refactor(SingOutButton): replaced api call to centralized function calls and updated choice types * Refactor(SignUpButton): replaced api calls to centralized function calls * Refactor(AllSignals): replaced api calls to centralized function calls * Refactor(EditSignal): replaced api call to centralized function call * Refactor(SignalDetail): replaced api calls to centralized function calls and updated choice types * Refactor(AllTrends): replaced api calls to centralized function calls * Refactor(EditTrend): replaced api call to centralized function call * Refactor(TrendDetail): replaced api calls to centralized function calls and updated choice types * Feat(asset): added hero image for easier relative import * Refactor(auth): cleaned up authentication flow via use of interceptor * Fix(Types): added missing attributes to types * Fix(MainBody): added missing attributes to api function call * Fix(PdfPageDesign): improved error handling for edge cases * Fix(EntryForms): added required parameters to api function calls * Fix(EditSignal/Trend): read using read endpoints instead of search endpoints * Fix(AllSignals/Trends): added proper status to filter for search * Refactor(minor): moved platform config to public folder * Fix(constants): refactored constants for consistency * Refactor(AuthConfig): renamed and refactored for consistency and readability * Fix(types): added created by attribute to fix updating params * Fix(api_config): increased timeout for image uploads and refactored auth process * Feat(App): logs out automatically if token is expired * Fix(main): minor import fix * Fix(addModals): added essential params * Fix(minor): import naming change * Fix(entryFormEl): added proper params for update and image display * Refactor(ci/cd): removed unused env variables and added new conditional variables for different branches * Refactor(CI/CD): improved conditional env variables * Fix(types): added created_for in signal create/update types * Fix(api): export endpoints response type set to blob for incoming binary data * Fix(entryForm): added missing types in update and create * Fix(entryFormEls): added missing params
* Fix(SignalEntryForm): added missing attributes for updating signal * Fix(api_config): automatic localStorage clearing if interceptor fails to refresh token * Refactor(errors): error handling message restructured to fit new response
GedionT
changed the title
Staging
Refactor: frontend modified to adapt to api change, authentication flow fix, and ci/cd change
Nov 6, 2024
mykolaskrynnyk
added
bug
Something isn't working
enhancement
New feature or request
labels
Nov 6, 2024
GedionT
changed the title
Refactor: frontend modified to adapt to api change, authentication flow fix, and ci/cd change
Refactor: Frontend modified to adapt to api change, Authentication flow change, Add card to PDF feature, and CI/CD updates
Nov 6, 2024
mykolaskrynnyk
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
This change introduces an update to API calls, Authentication flow, Card export feature, and CI/CD updates.