Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed default font size from 13px to 16px #2601

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

JinIgarashi
Copy link
Contributor

@JinIgarashi JinIgarashi commented Dec 29, 2023

Thank you for submitting a pull request!

Description

because UNDP design uses 16px as default font size

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others ()

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

┆Issue is synchronized with this Wrike task by Unito

@JinIgarashi JinIgarashi added the bug Something isn't working label Dec 29, 2023
@JinIgarashi JinIgarashi self-assigned this Dec 29, 2023
@auto-assign auto-assign bot requested review from iferencik and Thuhaa December 29, 2023 16:34
Copy link

changeset-bot bot commented Dec 29, 2023

🦋 Changeset detected

Latest commit: 9175546

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@undp-data/svelte-undp-design Patch
geohub Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JinIgarashi JinIgarashi merged commit fc17c92 into develop Dec 29, 2023
14 checks passed
@JinIgarashi JinIgarashi deleted the fix/font-size-16px branch December 29, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant