Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies of svelte to v5 for geohub #4683

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

JinIgarashi
Copy link
Contributor

@JinIgarashi JinIgarashi commented Dec 26, 2024

Thank you for submitting a pull request!

Description

#4333 can be partially fixed

So far, migrated all page.svelte

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others (migrate to svelte 5)

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

@JinIgarashi JinIgarashi added enhancement New feature or request refactor labels Dec 26, 2024
@auto-assign auto-assign bot requested a review from iferencik December 26, 2024 12:43
Copy link

changeset-bot bot commented Dec 26, 2024

🦋 Changeset detected

Latest commit: f5498a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
geohub Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@auto-assign auto-assign bot requested a review from Thuhaa December 26, 2024 12:43
@JinIgarashi JinIgarashi marked this pull request as draft December 26, 2024 12:44
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Components December 26, 2024 12:44 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Components December 27, 2024 08:54 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Components December 27, 2024 09:07 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Components December 27, 2024 12:42 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant