Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMS-461 separate function app #1056

Merged
merged 50 commits into from
Dec 10, 2024
Merged

CAMS-461 separate function app #1056

merged 50 commits into from
Dec 10, 2024

Conversation

jamesobrooks
Copy link
Contributor

@jamesobrooks jamesobrooks commented Dec 9, 2024 •
edited
Loading

Purpose

Describe the reason why this was developed.

Major Changes

Describe what has changed.

Testing/Validation

Enumerate on steps to validate that this feature is working.

Notes

Optional - capture notes for nuances or future work that could be done.

Definition of Done:

  • Acceptance criteria met - The system meets all acceptance criteria
  • Feature toggles created - Features that are deployed but not released have toggles
  • Design QA passed - All visual UI looks and works the way it’s supposed to
  • Usability validated - Team ensures the working code is easy to use
  • Accessibility tests passed - System passes automated and manual accessibility tests and supports applicable devices
  • Code refactored for clarity - Developers can understand the work simply by reviewing the code
  • Dependency Rule followed - More important code doesn’t directly depend on less important code
  • Development debt eliminated - UX and code aligns to the team’s latest understanding of the domain
  • Source code merged - Code has been merged into the main branch
  • 90% unit test coverage achieved - Automated test coverage tools indicate coverage of >= 90%
  • Code reviewed - Code is reviewed by at least two other team members before being merged
  • Code quality checks passed - Code passes all automated quality checks
  • Security scans passed - Code passes expected scans for vulnerabilities and compliance issues
  • Threat model updated - The threat model incorporates new threats and remediations
  • Build process updated - Automated build process include code supporting the user story
  • Load/performance tests passed - Performance tests include the functionality of the user story
  • Documents are updated - All required documentation is up to date and version controlled
  • Code is deployed - Code is deployed to the highest production like environment

btposey and others added 25 commits December 5, 2024 17:43
@btposey @fmaddenflx @jamesobrooks
Move lib up to backend directory to isolate az functions
9ec0b41 
Jira ticket: CAMS-461

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@btposey @fmaddenflx @jamesobrooks
Fix backend start path
05ed5c8 
Jira ticket: CAMS-461

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@jamesobrooks @fmaddenflx @amorrow-flexion
Change workflow paths to api
6abe1b2 
Jira ticket: CAMS-461

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
@jamesobrooks @fmaddenflx @amorrow-flexion
Fix remaining path issues
1135cff 
Jira ticket: CAMS-461

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
@jamesobrooks @fmaddenflx @amorrow-flexion
Fix backend zip creation
73ebee8 
Jira ticket: CAMS-461

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
@amorrow-flexion @fmaddenflx @jamesobrooks
separate durable function and workflow accomodations
d23584f 
refactor to create separate functionApps for durable
and non durable functions, updated workflows and scripts
to accomodate for the addition

Jira ticket: CAMS-461

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@amorrow-flexion
edited workflow to run ci properly on newly split functions
cbb097d 
Jira ticket: CAMS-461
@amorrow-flexion
corrected paths in pushd
0a9eb9e 
Jira ticket: CAMS-461
@amorrow-flexion
removed npm
d4b9822 
Jira ticket: CAMS-461
@amorrow-flexion
moved app insights and alert creation into one place
eb0765a 
Jira ticket: CAMS-461
@amorrow-flexion
added node dependency to backend
8c6b769 
Jira ticket: CAMS-461
@amorrow-flexion
added use-base for ci
61d2ecc 
Jira ticket: CAMS-461
@amorrow-flexion @jamesobrooks
created use-bash in package.json and corrected pack
9700e79 
Jira ticket: CAMS-461

Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: James Brooks <[email protected]>
@amorrow-flexion
fixed artifact path on build
0a99c0a 
Jira ticket: CAMS-461
@amorrow-flexion
addressed todo in bicep
8f80082 
Jira ticket: CAMS-461
@amorrow-flexion
fixed sql vnet rule fir migration functionapp
407dcd8 
Jira ticket: CAMS-461
@amorrow-flexion
fixed webapp name
33115ca 
[skip ci]

Jira ticket: CAMS-461
@amorrow-flexion
fixed dependency issue in network subnets
dbda733 
Jira ticket: CAMS-461
@amorrow-flexion @fmaddenflx @jamesobrooks
added stop operation to migration slot
180e6b9 
[skip ci]

Jira ticket: CAMS-461

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@amorrow-flexion @fmaddenflx @jamesobrooks
commented out prelim steps for now fixed appi dependencies
73270b7 
Jira ticket: CAMS-461

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@amorrow-flexion @jamesobrooks
corrected pack commands and az-delete-branch-resources
6231e1e 
Jira ticket: CAMS-461

Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: James Brooks <[email protected]>
@amorrow-flexion @jamesobrooks
fixed pack commands
75756c5 
Jira ticket: CAMS-461

Co-authored-by: James Brooks <[email protected]>
@amorrow-flexion @jamesobrooks
correctly used dirs in zip command for pack
7359f21 
Jira ticket: CAMS-461

Co-authored-by: James Brooks <[email protected]>
@amorrow-flexion
another attempt at pack commands
6210a16 
Jira ticket: CAMS-461
@amorrow-flexion
final attempt
a10905d 
Jira ticket: CAMS-461
jamesobrooks
jamesobrooks commented Dec 9, 2024
View reviewed changes
backend/package.json Outdated Show resolved Hide resolved
btposey
btposey reviewed Dec 10, 2024
View reviewed changes
user-interface/src/lib/utils/datetime.test.ts Outdated Show resolved Hide resolved
user-interface/src/lib/models/api2.test.ts Outdated Show resolved Hide resolved
user-interface/src/lib/models/api2.test.ts Outdated Show resolved Hide resolved
test/e2e/playwright/auth-setup.ts Outdated Show resolved Hide resolved
ops/scripts/pipeline/slots/az-slot-start-stop-operations.sh Outdated Show resolved Hide resolved
@amorrow-flexion amorrow-flexion merged commit 55f95f6 into CAMS-461-durable-function Dec 10, 2024
17 checks passed
@amorrow-flexion amorrow-flexion deleted the CAMS-461-separate-function-app branch December 10, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorrow-flexion amorrow-flexion amorrow-flexion approved these changes

@fmaddenflx fmaddenflx fmaddenflx approved these changes

@btposey btposey btposey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesobrooks @btposey @fmaddenflx @amorrow-flexion