CAMS-516 UseOutsideClick now acts on mousedown, not click #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira ticket: CAMS-516
fmaddenflx
commented
Jan 31, 2025
There was a problem hiding this comment.
Does it make sense to rename this hook, since it's no longer acting on "click" but rather "mousedown" ?
I think that perhaps we shouldn't rename it, because it's easier to remember that "hey I need to add an outside click handler to this thing" than it is to remember "hey I need to add a handler for mousedown to this thing."
Jira ticket: CAMS-516
jamesobrooks
approved these changes
Jan 31, 2025
|
I'm not sure we need the comment, but looks good. |
amorrow-flexion
approved these changes
Jan 31, 2025
fmaddenflx
deleted the
CAMS-516-combobox-click-outside-closes-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Bug Fix for -- comboBox outside click action was swallowing up the click event, such that if a user has the comboxOpen, and then clicks on a button, the comboBox closes but the button click is not handled.
Major Changes
Adjusted the UseOutsideClick hook to handle a "mousedown" event rather than a "click" event.
Testing/Validation
Manually tested using mouse and verified that keyboard interaction still works as expected.