Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMS-446 - Refactor ad_groups concatenation #932

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

btposey
Copy link
Contributor

@btposey btposey commented Sep 24, 2024

Purpose

Remove AD groups concatenation logic from HumbleVerifier

Major Changes

  • Remove AD groups concatenation logic from HumbleVerifier
  • Implement logic in OktaGateway

Testing/Validation

Unit tests pass.

Jira ticket: CAMS-446

Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@btposey btposey requested review from a team as code owners September 24, 2024 18:36
@btposey btposey merged commit e39ae54 into main Sep 24, 2024
14 checks passed
@btposey btposey deleted the CAMS-446-adgroups-bug branch September 24, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants