Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

334 output refactoring #14

Merged
merged 21 commits into from
Apr 16, 2024
Merged

334 output refactoring #14

merged 21 commits into from
Apr 16, 2024

Conversation

hausman-gdit
Copy link
Contributor

@hausman-gdit hausman-gdit commented Mar 18, 2024

Reduce redundant rendering code for different model or dataset type model outputs. This PR adds a new generic <Table> component; more work can be done in subsequent PRs to migrate hand-created react tables to use the table component.

# data type component completed
1 multitumor GoodnessFit
1 individual model GoodnessFit
2 multitumor InfoTable
2 individual model InfoTable
3 multitumor ModelOptions
3 individual model ModelOptionsTable
4 NestedDicho Summary
4 multitumor Summary
4 individual model ContinuousSummary
5 NestedDicho ModalBody
5 multitumor ModalBody
5 individual model ModelDetailsModel
6 NestedDicho ModelParameters
6 individual model ModelParameters
6 multitumor ParameterSettings

Additional changes:

  • Update python packages
  • Update ruff command (w/ package update)
  • Give OpenAPI endpoints unique names
  • Remove Lollipop chart
  • Fix test deprecation warnings

@hausman-gdit hausman-gdit marked this pull request as ready for review April 9, 2024 14:14
@shapiromatron shapiromatron merged commit 5bdacc6 into main Apr 16, 2024
3 checks passed
@shapiromatron shapiromatron deleted the 334-output-refactoring branch April 16, 2024 20:25
@shapiromatron shapiromatron mentioned this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants