Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swg UI 2 #17

Merged
merged 17 commits into from
Apr 30, 2024
Merged

Swg UI 2 #17

merged 17 commits into from
Apr 30, 2024

Conversation

shapiromatron
Copy link
Collaborator

@shapiromatron shapiromatron commented Apr 24, 2024 •
edited
Loading

Related: https://github.com/USEPA/bmds-private/pull/17

Continued user interface updates from second round of review:

  • Remove "frequentist" form model selection menu
  • Update model recommendation footnote
  • Provide a default footnote when a user makes a model selection
  • Change header for Log-likelihood value in some cases
  • Fix observed data text label
  • Add Model to the end of individual model summary
  • Show BMD/BMDL/BMDU lines on BMD CDF plot
  • Add hover description to describe each continuous Test 1-4

In addition:

  • Change HTML browser window title to more quickly show the current analysis
  • Update version to include pybmds version
  • Update code to work with updated pybmds
  • Update ruff version
  • Add a few more API tests (84% -> 86%)
  • Remove table-bordered class from all tables
  • Make table footnote text small

@shapiromatron
remove frequentist from top user interface
6296501
@shapiromatron
update default recommendation footnote
e1c815b
@shapiromatron
update default footnote when model is selected
4b1bb90
@shapiromatron
LLR changes
e551d08
@shapiromatron
use preferred data names
2b37d38
@shapiromatron
refactor version setup
6368b4b
@shapiromatron
update citation to use version instead of sha
f277049
@shapiromatron
Merge branch 'main' into swg-ui-2
f789326 
# Conflicts:
#	bmds_server/analysis/validators/session.py
#	frontend/src/components/IndividualModel/ContinuousDeviance.js
#	frontend/src/components/IndividualModel/ContinuousTestOfInterest.js
#	frontend/src/components/IndividualModel/DichotomousDeviance.js
@shapiromatron
bump ruff format
25eff13
@shapiromatron
write a few more tests
8e113b2
@shapiromatron
change order of title
196ec0b
@shapiromatron
add Model to end of modal model name
31a8d56
@shapiromatron
rename/simplify modal code
c689555
@shapiromatron
add CDF lines
b2eff53
@shapiromatron
remove table-bordered class
fdf0342
@shapiromatron
make footnote text smaller
e570c65
@shapiromatron
make footnote next smaller
f0a7769
@shapiromatron shapiromatron marked this pull request as ready for review April 30, 2024 20:37
@shapiromatron shapiromatron merged commit 7be9be5 into main Apr 30, 2024
3 checks passed
@shapiromatron shapiromatron deleted the swg-ui-2 branch April 30, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shapiromatron