Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop robustness updates #53

Merged
merged 14 commits into from
Aug 3, 2024
Merged

Desktop robustness updates #53

merged 14 commits into from
Aug 3, 2024

Conversation

shapiromatron
Copy link
Collaborator

@shapiromatron shapiromatron commented Jul 23, 2024

Assorted Desktop changes to attempt to improve the overall stability of the BMDS Desktop application.

  • Search and detect a free port instead of failing if a port is currently being used, and then wait for a period (60 sec) until the port is free instead of instantly failing
  • Allow a user to specify a configuration path on command-line startup
  • Throw a custom DesktopException instead of generic exceptions when running via CLI
  • Setup logging as a function that can be called in desktop settings
  • Update default configuration paths to be consistent with other common Python tools
  • Disable pypi version check for now

In addition

  • Temporarily disable nested dichotomous from user interface and xfail tests after BMDS-49
  • Add basic documentation for bmds-ui, with screenshots and a few key differences between BMDS Online and BMDS Desktop

Finally, we reorganized paths to make the user-interface more future proof. The configuration file is now named config_v{version} where version is the version of the current configuration spec (so currently 1). The static html/css files that are used by the application are stored in a folder w/ the bmds-ui version. That way, the static files are pinned to the minor release, but the configuration file is no longer pinned to the minor release but instead the current configuration file version. That will allow us to update the user-interface and create a new folder for the new UI, but as long as the configuration format is the same, we can use across future versions.

You could also add a migration script so that if v1 is found, you could migrate to v2, should that be appropriate.

@shapiromatron shapiromatron changed the title Desktop Desktop robustness updates Jul 23, 2024
@shapiromatron shapiromatron merged commit bfbc081 into main Aug 3, 2024
3 checks passed
@shapiromatron shapiromatron deleted the desktop branch August 3, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant