Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement nested logistic #59

Merged
merged 13 commits into from
Aug 15, 2024
Merged

Implement nested logistic #59

merged 13 commits into from
Aug 15, 2024

Conversation

shapiromatron
Copy link
Collaborator

@shapiromatron shapiromatron commented Aug 13, 2024 •
edited
Loading

Updates w/ recent implementation of nested logistic in USEPA/BMDS#51.

The following changes were made to nested dichotomous modeling options:

  • Restore execution of nested dichotomous models
  • Change order of lsc and ilc runs to be consistent with BMDS Excel
  • Properly specify parameter priors based on model selection
  • Numerous UI improvements to outputs
  • No longer report BMDU because the value is not calculated in bmdscore
  • Change example dataset to a well-behaved dataset

In addition:

  • Fix error rendering error when a API request returns a non-pydantic error
  • Add a few more coverage reporting rules

@shapiromatron shapiromatron marked this pull request as ready for review August 15, 2024 01:06
@shapiromatron shapiromatron changed the title Nlogistic Implement nested logistic Aug 15, 2024
@shapiromatron shapiromatron merged commit 8626276 into main Aug 15, 2024
3 checks passed
@shapiromatron shapiromatron deleted the nlogistic branch August 15, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shapiromatron