Add EPANETMSX support to WNTR #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class will be similar to the WaterNetworkModel in terms of its structure and options.
Merge main into development branch
Citations
Update to add basic citation class
Exceptions
* Update to exception documentation * Update documentation for EN errors
All os/version combos are failing in the threading test, including using the old binaries. Trying to turn off the test first to see if it can get past this test.
|
I managed to mess up the PR by rebasing the last commits (it vanished) so this is the recreated. I do need to move shell/apple/libomp.rb still |
|
Closing this PR and re-opening the original PR to keep the comments record. |
|
Well, PR #426 did not allow itself to be reopened anyway, so please look at that PR also for the history of comments on changes as they were prepped. Repoening. |
Also adds the ruby brew formula to the manifest for source distributions.
|
@kaklise The last two pushes have fixed the outstanding issues with the msx_as files, moving the brew formula, and adding information on MacOS builds using homebrew to the installation section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes needed to support EPANETMSX with WNTR.
Summary
This feature adds EPANETMSX library support to WNTR. It also includes updates to the build process to allow MacOS-ARM support.
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.