Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update app to support multi years #334

Merged
merged 71 commits into from
Aug 16, 2023

Conversation

courtneymyers
Copy link
Collaborator

Related Issues:

  • CSBAPP-194

Main Changes:

Major update to the app to allow for the new 2023 rebate year of submissions. Initially supports the new 2023 FRF form, but lays the groundwork for the remaining two 2023 forms, and future rebate year forms.

Steps To Test:

  1. Navigate to the dashboard.
  2. Change "Rebate Year" to 2023, and ensure the form submissions shown below reflect the new rebate year (will display the "Please select the “New Application” button..." message initially until you create your first 2023 FRF submission).
  3. Create a new FRF submission for 2023, and ensure you're re-directed to the correct page to continue editing the form.
  4. Navigate back to the dashboard, and switch "Rebate Year" back to 2022, and ensure 2022 form submissions display properly.
  5. Navigate directly to an old 2022 form submission via the old URL (e.g. "/rebate/644034b7ed3e46078d54cc99") and ensure you're redirected to the new URL (e.g. "/frf/2022/644034b7ed3e46078d54cc99")

TODO:

  • Nothing to do until post-v4 release when the BAP has built out their 2023 FRF functionality, but eventually we'll want to update the app to fetch 2023 FRF data from the BAP and update the setting of the 2023 FRF submission statuses to account for that.

…l rebates page) and update styles (shrink buttons, update small screen layout)
…link to the right of the new rebate year select
…on text components for dashboard, helpdesk, and signout (less dry but also less indirection)
… and update rebate year select in allRebates component to use it
…status, and update API to return those values and code to reflect they're now each stored at the year level too
…se it in checkFormSubmissionPeriodAndBapStatus() function
…s for controlling each form's open enrollment status
…formio2022.js route file and into a new formio.js utility file (for use in a new formio2023.js route file)
…fig and update formio s3 functions to use it in determining the formio form url
…d of individual form url variables, and remove no longer used individual form url variables
… of referencing the formio formUrl object every time
…023 (and update initial submission data fields to reflect changes made to 2023 FRF)
…22 form submissions, and add Formio 2023 FRF submission type
…iveryDate field's value discrepancy between the returned data of null and the rendered value of any empty string
…orrect combo key field can be used, based on the rebate year
…data, and rename 2022 queries and hooks to reflect 2022 rebate year
…r fetching data and rendering content, based on rebate year
…2023 rebates, and update Submissions2023 component to render 2023 FRF submissions in the table

const router = express.Router();

router.use(ensureAuthenticated);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.

const router = express.Router();

router.use(ensureAuthenticated);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.

const router = express.Router();

router.use(ensureAuthenticated);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.

const router = express.Router();

router.use(ensureAuthenticated);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.

const router = express.Router();

router.use(ensureAuthenticated);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
@courtneymyers courtneymyers merged commit 57b3618 into develop Aug 16, 2023
1 of 2 checks passed
@courtneymyers courtneymyers deleted the feature/update-app-to-support-multi-years branch August 16, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant