Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/enable cors on nces endpoint #339

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Feature/enable cors on nces endpoint #339

merged 2 commits into from
Aug 23, 2023

Conversation

courtneymyers
Copy link
Collaborator

Related Issues:

  • CSBAPP-7

Main Changes:

Update Formio NCES web service endpoint to allow cross origin requests if running the app locally.

Steps To Test:

  1. Run the app locally. The Formio NCES web service endpoint should now resolve correctly, as CORS is enabled for this route.

@courtneymyers
Update Formio NCES web service endpoint to allow cross origin request…
8254caa 
…s if running the app locally
@courtneymyers
Update enableLocalhostCORS middleware to check request host for local…
afe8790 
…host, since deployed app's NODE_ENV will be set to production on Cloud.gov
@courtneymyers courtneymyers merged commit 1c3f5f1 into develop Aug 23, 2023
1 check passed
@courtneymyers courtneymyers deleted the feature/enable-cors-on-nces-endpoint branch August 23, 2023 14:57
@courtneymyers courtneymyers mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@courtneymyers