Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update fetch data for prf submission #450

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

courtneymyers
Copy link
Collaborator

Related Issues:

  • CSBAPP-276

Main Changes:

Update fetchDataForPRFSubmission()'s handling of fetched 2023 data to account for when bus record contact data from the BAP doesn't include any Account (org) info. In practice, each bus contact returned from the BAP should have an org associated with it, but in testing on dev, one of my contacts did not have any "Account" info returned. That really should never occur in production, but this fix just ensures the app doesn't crash if that were to occur.

Steps To Test:

  1. Navigate to the dashboard
  2. Click "New Payment Request" button to create a new payment request form submission from a selected FRF.
  3. If the corresponding FRF data returned from the BAP (and injected as initial form data for the PRF) doesn't include any org info for one of the bus contacts (which should never actually happen), the app should function normally (there would just likely be missing organizations data injected into the new PRF submission).

… account for when bus record contact data from the BAP doesn't include any Account (org) info
@courtneymyers courtneymyers merged commit ec7f1e6 into develop Jun 10, 2024
1 check passed
@courtneymyers courtneymyers deleted the feature/update-fetch-data-for-prf-submission branch June 10, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant