Set Node positions on load #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of nodes) instead of our array of nodes. This means that the node positions are only calculated once and stored, instead of recalculating every time the node changes (which is not necessarily a problem but this prevents the nodes from overlapping on each other)
since we build a temporary tree and set the node positions upon loading the config, we don't need set the layout elements every time we dispatch a node changing action
clarify types between position unaware and position aware decision trees
separate interfaces for config objects and objects in store, add rank to position property in our decision tree
…k usage
increment version
fix typescript build error in test file
dpgraham4401
force-pushed
the
set_positions_on_load
branch
from
a249220 to
e6c0092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug fix (conveniently also a performance optimization) that sets node positions for the entire tree upon loading the config. This means that our store does not have to recaclulate node position every time and, upon doing so, the nodes do not overlap.
Issue ticket number and link
Checklist