Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close niblings (nieces & nephews) #23

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Close niblings (nieces & nephews) #23

merged 8 commits into from
Feb 5, 2024

Conversation

dpgraham4401
Copy link
Member

Description

This PR adds the functionality to close all "Niblings" (a slang, gender-neutral term we've adopted for both nieces and nephews) of a node. So when a node is opened, if that node has siblings, the sibnling's descdants will be closed to

  1. avoid the possibility of overlapping nodes (which shouldn't be a problem but this will help clean the UI looking clean and may be useful for additional functionlity in the future)
  2. make it clear that one of the paths must be chosen, you can't have it both ways. We don't want to confuse users by having multiple requirements upon.

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions github-actions bot added dependencies changes to our dependencies documentation Improvements or additions to documentation labels Feb 5, 2024
@dpgraham4401 dpgraham4401 merged commit e17f0fa into main Feb 5, 2024
5 checks passed
@dpgraham4401 dpgraham4401 deleted the close_niblings branch February 5, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes to our dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant