Merge pull request #500 from MetaPhase-Consulting/fix/pert-int-str

Fixing redundant data transform to str from int
USStateDept · Apr 13, 2021 · 1891084 · 1891084
2 parents 88e6a9c + b25a835
commit 1891084
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/talentmap_api/fsbid/services/bid.py b/talentmap_api/fsbid/services/bid.py
@@ -192,8 +192,8 @@ def fsbid_bid_to_talentmap_bid(data):
         data.get('handshake_allowed_ind')
     )
     canDelete = True if data.get('delete_ind', 'Y') == 'Y' else False
-    cpId = int(float(data.get('cp_id')))
-    perdet = str(int(data.get('perdet_seq_num')))
+    cpId = int(data.get('cp_id'))
+    perdet = str(data.get('perdet_seq_num'))
 
     return {
         "id": f"{perdet}_{cpId}",

diff --git a/talentmap_api/fsbid/services/client.py b/talentmap_api/fsbid/services/client.py
@@ -243,14 +243,14 @@ def fsbid_clients_to_talentmap_clients(data):
     middle_name = get_middle_name(employee)
 
     return {
-        "id": str(int(employee.get("pert_external_id", None))),
+        "id": str(employee.get("pert_external_id", None)),
         "name": f"{employee.get('per_first_name', None)} {middle_name['full']}{employee.get('per_last_name', None)}",
         "shortened_name": f"{employee.get('per_first_name', None)} {middle_name['initial']}{employee.get('per_last_name', None)}",
         "initials": initials,
-        "perdet_seq_number": str(int(employee.get("perdet_seq_num", None))),
+        "perdet_seq_number": str(employee.get("perdet_seq_num", None)),
         "grade": employee.get("per_grade_code", None),
         "skills": map_skill_codes(employee),
-        "employee_id": str(int(employee.get("pert_external_id", None))),
+        "employee_id": str(employee.get("pert_external_id", None)),
         "role_code": data.get("rl_cd", None),
         "pos_location": map_location(location),
         # not exposed in FSBid yet
@@ -593,7 +593,7 @@ def fsbid_available_bidder_to_talentmap(data):
     middle_name = get_middle_name(employee)
 
     res = {
-        "id": str(int(employee.get("pert_external_id", None))),
+        "id": str(employee.get("pert_external_id", None)),
         "cdo": {
             "full_name": data.get('cdo_fullname', None),
             "last_name": data.get('cdo_last_name', None),
@@ -604,10 +604,10 @@ def fsbid_available_bidder_to_talentmap(data):
         "name": f"{employee.get('per_first_name', None)} {middle_name['full']}{employee.get('per_last_name', None)}",
         "shortened_name": f"{employee.get('per_first_name', None)} {middle_name['initial']}{employee.get('per_last_name', None)}",
         "initials": initials,
-        "perdet_seq_number": str(int(employee.get("perdet_seq_num", None))),
+        "perdet_seq_number": str(employee.get("perdet_seq_num", None)),
         "grade": employee.get("per_grade_code", None),
         "skills": map_skill_codes(employee),
-        "employee_id": str(int(employee.get("pert_external_id", None))),
+        "employee_id": str(employee.get("pert_external_id", None)),
         "role_code": data.get("rl_cd", None),
         "pos_location": map_location(location),
         # not exposed in FSBid yet

diff --git a/talentmap_api/fsbid/views/employee.py b/talentmap_api/fsbid/views/employee.py
@@ -26,7 +26,7 @@ def put(self, request, *args, **kwargs):
 
         if emp_id is not None:
             user = request.user.profile
-            user.emp_id = str(int(emp_id))
+            user.emp_id = str(emp_id)
             user.save()
 
         auth_user = request.user