Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main_2024.py detect target #156

Merged
merged 36 commits into from
Feb 17, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
2dbe3c9
added annotated image option
Ethan118 Nov 13, 2023
10c489e
integrated in main_2024
Ethan118 Nov 13, 2023
bfa1978
added cli option
Ethan118 Nov 27, 2023
ad9ac08
added window closing
Ethan118 Nov 27, 2023
f23f62d
fixed unit tests
Ethan118 Nov 28, 2023
dd6e5a1
fixed image annotation and modified test cases
Ethan118 Nov 28, 2023
3ee9905
converted unit tests to use bounding boxes
Ethan118 Nov 30, 2023
d7ca078
added device to predict arg
Ethan118 Nov 30, 2023
8819c3c
added annotated image option
Ethan118 Nov 13, 2023
d08e556
integrated in main_2024
Ethan118 Nov 13, 2023
bd2a59d
added cli option
Ethan118 Nov 27, 2023
a49c660
added window closing
Ethan118 Nov 27, 2023
20e4018
fixed unit tests
Ethan118 Nov 28, 2023
0da5e01
fixed image annotation and modified test cases
Ethan118 Nov 28, 2023
37a37bc
converted unit tests to use bounding boxes
Ethan118 Nov 30, 2023
cb186f4
added device to predict arg
Ethan118 Nov 30, 2023
724de57
remove annotated image from function return
Ethan118 Dec 4, 2023
5e6c8e7
added hardcoded values for testing target detection
Ethan118 Jan 16, 2024
0133d97
fixed conflicts
Ethan118 Jan 16, 2024
479a361
Changed tests to use absolute error tolerance, Added checks for numbe…
Ethan118 Jan 27, 2024
864bcaa
Merge branch 'main' into detect_target-integration
Ethan118 Jan 27, 2024
0b2f4b7
edited paths to use pathlib
Ethan118 Feb 5, 2024
ba05393
Fixed tests to use detections and time object
Ethan118 Feb 5, 2024
108c7c6
merged with main
Ethan118 Feb 5, 2024
ca549ba
fixed path errors in build
Ethan118 Feb 5, 2024
0ab48c9
Offloaded fixture setup to a separate function and added comments
Ethan118 Feb 6, 2024
435992c
Cleaned up test_detect_target and generate_expected
Ethan118 Feb 7, 2024
73a28a8
Fixed formatting
Ethan118 Feb 7, 2024
69be32a
Fixed renamed variables
Ethan118 Feb 7, 2024
5117781
Changed tolerance
Ethan118 Feb 8, 2024
dea615a
Merge branch 'main' into detect_target-integration
Ethan118 Feb 8, 2024
3080db0
fixed create detections
Ethan118 Feb 8, 2024
6b00c7e
Set tolerance to 0 and fixed formatting
Ethan118 Feb 9, 2024
ef80b03
Changed formatting mostly multiline
Ethan118 Feb 14, 2024
68fab82
Final formatting changes, Updated test_detect_target_worker to use de…
Ethan118 Feb 17, 2024
f8359ec
Some refactoring of main_2024 and final formatting changes
Ethan118 Feb 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions main_2024.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line 12 import (no longer being used).

Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from modules.detect_target import detect_target_worker
from modules.flight_interface import flight_interface_worker
from modules.video_input import video_input_worker
from modules.detections_and_time import DetectionsAndTime


CONFIG_FILE_PATH = pathlib.Path("config.yaml")
Expand Down Expand Up @@ -43,6 +44,7 @@ def main() -> int:
parser = argparse.ArgumentParser()
parser.add_argument("--cpu", action="store_true", help="option to force cpu")
parser.add_argument("--full", action="store_true", help="option to force full precision")
parser.add_argument("--show-annotated", action="store_true", help="option to show annotated image")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make multiline.

args = parser.parse_args()

# Set constants
Expand All @@ -58,6 +60,7 @@ def main() -> int:
DETECT_TARGET_MODEL_PATH = config["detect_target"]["model_path"]
DETECT_TARGET_OVERRIDE_FULL_PRECISION = args.full
DETECT_TARGET_SAVE_PREFIX = config["detect_target"]["save_prefix"]
DETECT_TARGET_ANNOTATE = args.show_annotated
Xierumeng marked this conversation as resolved.
Show resolved Hide resolved

FLIGHT_INTERFACE_ADDRESS = config["flight_interface"]["address"]
FLIGHT_INTERFACE_WORKER_PERIOD = config["flight_interface"]["worker_period"]
Expand Down Expand Up @@ -104,6 +107,7 @@ def main() -> int:
DETECT_TARGET_MODEL_PATH,
DETECT_TARGET_OVERRIDE_FULL_PRECISION,
DETECT_TARGET_SAVE_PREFIX,
DETECT_TARGET_ANNOTATE,
video_input_to_detect_target_queue,
detect_target_to_main_queue,
controller,
Expand All @@ -129,9 +133,9 @@ def main() -> int:

while True:
try:
image = detect_target_to_main_queue.queue.get_nowait()
detections = detect_target_to_main_queue.queue.get_nowait()
except queue.Empty:
image = None
detections = None
Xierumeng marked this conversation as resolved.
Show resolved Hide resolved

odometry_and_time = flight_interface_to_main_queue.queue.get()

Expand All @@ -145,10 +149,10 @@ def main() -> int:
print("pitch: " + str(odometry_and_time.odometry_data.orientation.pitch))
print("")

if image is None:
if detections is None:
continue

cv2.imshow("Landing Pad Detector", image)
#cv2.imshow("Landing Pad Detector", image)
Trotyl15 marked this conversation as resolved.
Show resolved Hide resolved

if cv2.waitKey(1) & 0xFF == ord('q'):
break
Expand All @@ -164,6 +168,8 @@ def main() -> int:
detect_target_manager.join_workers()
flight_interface_manager.join_workers()

cv2.destroyAllWindows()

return 0


Expand Down
13 changes: 7 additions & 6 deletions modules/detect_target/detect_target.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to when you were displaying the image in run() . Return only the detections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amy mentioned above that this causes issues. Is there a work around?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work on you end? If it does then maybe I missed something in the set up?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try adding cv2.waitKey(1) after the imshow() ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try adding cv2.waitKey(1) after the imshow() ?

Oh this works! @Ethan118 you can do this instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line 7 import (no longer being used).

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class DetectTarget:
"""
Contains the YOLOv8 model for prediction.
"""
def __init__(self, device: "str | int", model_path: str, override_full: bool, save_name: str = ""):
def __init__(self, device: "str | int", model_path: str, override_full: bool, save_name: str = "", show_annotations: bool = False):
Xierumeng marked this conversation as resolved.
Show resolved Hide resolved
"""
device: name of target device to run inference on (i.e. "cpu" or cuda device 0, 1, 2, 3).
model_path: path to the YOLOv8 model.
Expand All @@ -28,16 +28,16 @@ def __init__(self, device: "str | int", model_path: str, override_full: bool, sa
self.__model = ultralytics.YOLO(model_path)
self.__counter = 0
self.__enable_half_precision = False if self.__device == "cpu" else True
self.__show_annotations = show_annotations
if override_full:
self.__enable_half_precision = False
self.__filename_prefix = ""
if save_name != "":
self.__filename_prefix = save_name + "_" + str(int(time.time())) + "_"

def run(self, data: image_and_time.ImageAndTime) -> "tuple[bool, np.ndarray | None]":
def run(self, data: image_and_time.ImageAndTime) -> "tuple[bool, detections_and_time.DetectionsAndTime | None]":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make multiline.

"""
Returns annotated image.
TODO: Change to DetectionsAndTime
"""
image = data.image
predictions = self.__model.predict(
Expand All @@ -50,7 +50,6 @@ def run(self, data: image_and_time.ImageAndTime) -> "tuple[bool, np.ndarray | No
if len(predictions) == 0:
return False, None

# TODO: Change this to DetectionsAndTime for image and telemetry merge for 2024
image_annotated = predictions[0].plot(conf=True)

# Processing object detection
Expand Down Expand Up @@ -84,7 +83,9 @@ def run(self, data: image_and_time.ImageAndTime) -> "tuple[bool, np.ndarray | No

self.__counter += 1

# TODO: Change this to DetectionsAndTime
return True, image_annotated
if self.__show_annotations:
cv2.imshow("Annotated Image", image_annotated)

return True, detections
Copy link
Member

@Trotyl15 Trotyl15 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work on your end? I don't think cv2.imshow is thread safe. Maybe consider passing image_annotated to the main process and display it from there instead of in worker process or implement locks.

Copy link
Collaborator

@Xierumeng Xierumeng Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably isn't threadsafe, but since only a single process will be using it, it should be fine. The Autonomy bootcamp is an example of where it works without issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a little test and when cv2.imshow was placed in worker process, the window freezes at start up my machine. For where it's currently placed, it works fine. Not sure if it's the same case with @Ethan118


# pylint: enable=too-few-public-methods
3 changes: 2 additions & 1 deletion modules/detect_target/detect_target_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def detect_target_worker(device: "str | int",
model_path: str,
override_full: bool,
save_name: str,
show_annotations: bool,
input_queue: queue_proxy_wrapper.QueueProxyWrapper,
output_queue: queue_proxy_wrapper.QueueProxyWrapper,
controller: worker_controller.WorkerController):
Expand All @@ -23,7 +24,7 @@ def detect_target_worker(device: "str | int",
input_queue and output_queue are data queues.
controller is how the main process communicates to this worker process.
"""
detector = detect_target.DetectTarget(device, model_path, override_full, save_name)
detector = detect_target.DetectTarget(device, model_path, override_full, save_name, show_annotations)

while not controller.is_exit_requested():
controller.check_pause()
Expand Down
Loading