Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python formatting tools #165

Merged
merged 18 commits into from
Mar 24, 2024
Merged

Python formatting tools #165

merged 18 commits into from
Mar 24, 2024

Conversation

Xierumeng
Copy link
Collaborator

Added Black formatter and addressed all Pylint linter issues.

@Xierumeng Xierumeng force-pushed the formatting-tools branch 2 times, most recently from 540eae0 to caea728 Compare February 19, 2024 07:46
mgupta27
mgupta27 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@mgupta27 mgupta27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xierumeng Xierumeng requested a review from mgupta27 February 24, 2024 05:05
TongguangZhang
TongguangZhang reviewed Mar 23, 2024
View reviewed changes
Copy link
Contributor

@TongguangZhang TongguangZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed - Use f-strings and ignore formatter for matrices.

modules/detections_and_time.py Outdated Show resolved Hide resolved
modules/detections_and_time.py Outdated Show resolved Hide resolved
modules/drone_odometry_local.py Outdated Show resolved Hide resolved
modules/drone_odometry_local.py Outdated Show resolved Hide resolved
modules/geolocation/camera_properties.py Outdated Show resolved Hide resolved
tests/unit/test_camera_properties.py Outdated Show resolved Hide resolved
tests/unit/test_geolocation.py Outdated Show resolved Hide resolved
tests/unit/test_geolocation.py Outdated Show resolved Hide resolved
tests/unit/test_geolocation.py Outdated Show resolved Hide resolved
tests/unit/test_geolocation.py Outdated Show resolved Hide resolved
TongguangZhang
TongguangZhang reviewed Mar 24, 2024
View reviewed changes
Copy link
Contributor

@TongguangZhang TongguangZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Not sure if I'm wrong here but it seems the formatter missed some lines that are over 100 characters?

modules/detections_and_time.py Outdated Show resolved Hide resolved
modules/geolocation/camera_properties.py Show resolved Hide resolved
modules/drone_odometry_local.py Show resolved Hide resolved
modules/detections_and_time.py Outdated Show resolved Hide resolved
modules/detections_and_time.py Outdated Show resolved Hide resolved
modules/drone_odometry_local.py Show resolved Hide resolved
modules/drone_odometry_local.py Show resolved Hide resolved
modules/drone_odometry_local.py Show resolved Hide resolved
modules/merged_odometry_detections.py Outdated Show resolved Hide resolved
modules/odometry_and_time.py Outdated Show resolved Hide resolved
TongguangZhang
TongguangZhang approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@TongguangZhang TongguangZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xierumeng Xierumeng merged commit 5487cf0 into main Mar 24, 2024
1 check passed
@Xierumeng Xierumeng deleted the formatting-tools branch March 24, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TongguangZhang TongguangZhang TongguangZhang approved these changes

@Trotyl15 Trotyl15 Awaiting requested review from Trotyl15

@AaronWang04 AaronWang04 Awaiting requested review from AaronWang04

@mgupta27 mgupta27 Awaiting requested review from mgupta27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xierumeng @mgupta27 @TongguangZhang