Added multiprocessing logging module #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TongguangZhang
commented
Mar 24, 2024
Comment on lines
+4
to
+8
| DEBUG = logging.DEBUG | ||
| INFO = logging.INFO | ||
| WARNING = logging.WARNING | ||
| ERROR = logging.ERROR | ||
| CRITICAL = logging.CRITICAL |
There was a problem hiding this comment.
this so so that modules trying to log don't have to import the logging module just for the logging levels
There was a problem hiding this comment.
Nit: Can we create a separate file and store these values as an enum?
Comment on lines
10
to
15
| def message_and_metadata(message, frame): | ||
| function_name = frame.f_code.co_name | ||
| filename = frame.f_code.co_filename | ||
| line_number = inspect.getframeinfo(frame).lineno | ||
|
|
||
| return f'[{filename} | {function_name} | {line_number}] {message}' |
There was a problem hiding this comment.
the frame object cannot be pickled so you can't put it in a queue, this is why we need this helper function, since we probably don't want to write this every time we want to log
modules/video_input/video_input.py
Outdated
Comment on lines
34
to
35
| multiprocess_logging.log_message(f'image size {image.shape}', multiprocess_logging.DEBUG, frame, self.logging_queue) | ||
| # self.logging_queue.queue.put((multiprocess_logging.message_and_metadata(f'image size {image.shape}', frame), logging.DEBUG), block=False) |
There was a problem hiding this comment.
these are the 2 methods I'm thinking about using right now - the second method is more consistent with our current modules, where we put things in queues, the first method is more similar to how the default logging module is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logging example in main_2024 and video_input